Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Facing the situation where Chinese users are unable to use Git, Huggingface, and Pipy normally. I hope to add proxy functionality. #450

Open
Ryden-kai opened this issue Dec 7, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Ryden-kai
Copy link

Ryden-kai commented Dec 7, 2024

Prerequisites

  • I have searched the existing issues and checked the recent builds/commits
  • I have read the documentation and this feature is not already available
  • This is a single feature request (not multiple features combined)

Problem StatementPain points for Chinese users:

  1. I hope only ComfyUI can use the proxy. Other programs on the computer are using the Chinese network normally.
  2. Environment variables cannot be changed. Changing environment roll variables can be done using a mirrored URL.

Proposed SolutionYou can choose the following ways to implement it:

  1. Add an environment variable setting function, allowing users to freely set environment variables. Give ComfyUI a higher degree of freedom.
  2. Use the terminal to run the agent. For example: ComfyUI.exe -- proxy http://127.0.0.1:7890
    image ( https://github.com/user-attachments/assets/3526cb86-5a30-44ae-8ec5-0c04f44e5a9e )
  3. Add a proxy button and proxy link to the ComfyUI interface, and remind users to restart ComfyUI after enabling or disabling the proxy button to have an effect.

Potential workflow

  1. Determine proxy link
  2. Enable or disable proxy

Impact LevelCritical (Blocking my work)

Alternatives ConsideredNo response

Additional informationNo response

┆Issue is synchronized with this Notion page by Unito

@robinjhuang
Copy link
Member

Makes sense! We are planning to add this. Are there any other features that would be helpful for users in China? Mirror urls etc?

@LiJT
Copy link

LiJT commented Dec 15, 2024

Yes need this function so bad

@zhaoqi571436204
Copy link

It is very important. In China, installation is a problem without mirrors.

@teward
Copy link
Collaborator

teward commented Dec 15, 2024

Makes sense! We are planning to add this. Are there any other features that would be helpful for users in China? Mirror urls etc?

I'm curious, wouldn't setting system proxy be sufficient? Is there a direct need to code the proxy functionality into Comfy?

@Ryden-kai
Copy link
Author

Makes sense! We are planning to add this. Are there any other features that would be helpful for users in China? Mirror urls etc?
Sure, on behalf of Chinese users, I would like to thank the developers of Comfy Org/desktop.
The following are the relevant mirror source websites in China
1 huggingface: https://hf-mirror.com/
2 pip : https://mirrors.tuna.tsinghua.edu.cn/pypi/web/simple
Others hope that Chinese users can see and help supplement it

@Ryden-kai
Copy link
Author

Makes sense! We are planning to add this. Are there any other features that would be helpful for users in China? Mirror urls etc?

I'm curious, wouldn't setting system proxy be sufficient? Is there a direct need to code the proxy functionality into Comfy?
I hope that only Comfyui uses a proxy network, while the system and other software use the Chinese network. Some other software cannot use networks outside of China

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants