You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues and checked the recent builds/commits
I have read the documentation and this feature is not already available
This is a single feature request (not multiple features combined)
Problem StatementIt would be great to have ComfyUI available as a winget-pkgs ( https://github.com/microsoft/winget-pkgs ) package, so it could simply be installed on windows via winget install ComfyUI. This would involve publishing github releases as other archive formats like standard zip.
Proposed SolutionOnce releases are available as msi/exe or zip, one can even setup a winget-releaserv2 github action workflow so every new github release gets automatically pushed to the winget-pkgs repo.
@jo-chemla Does it need to be published on Github releases? In your PR you are using the download.comfy.org URL, which will always point to the latest release. Also, does it need to be zip? We use the NSIS installer right now, not Squirrel for Windows.
We can also publish Github releases, but we use ToDesktop as our build system right now for code-signing so will require a bit more work to include the builds here as well.
The PR has been withheld by winget-pkgs team because this permanent download url returns an installer which might have a hash that differs from the hash of the installer of when version that was submitted/PR'ed. Hence it is easier to have one package url per version if the installer, and a lot of winget-pkgs rely on github releases.
Github releases do not need to be signed tor the winget team to accept the package to my understanding, so maybe you could just use the winget-releaser v2 action and it should be good to go.
Finally regarding type of installer, as long as this is not a scripted application with bat, it can be a zip with portable executable, or installer exe or msi, there are lots of different types of packages and the choice is up to you!
Prerequisites
Problem StatementIt would be great to have ComfyUI available as a winget-pkgs ( https://github.com/microsoft/winget-pkgs ) package, so it could simply be installed on windows via winget install ComfyUI. This would involve publishing github releases as other archive formats like standard zip.
Proposed SolutionOnce releases are available as msi/exe or zip, one can even setup a winget-releaserv2 github action workflow so every new github release gets automatically pushed to the winget-pkgs repo.
Potential workflow
Impact LevelHigh (Major improvement)
Alternatives ConsideredIssue on the comfyanonymous/ComfyUI repo here comfyanonymous/ComfyUI#5310
Additional informationNo response
┆Issue is synchronized with this Notion page by Unito
The text was updated successfully, but these errors were encountered: