Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Publish comfyui-desktop to github releases #455

Open
jo-chemla opened this issue Dec 9, 2024 · 2 comments
Open

[Feature Request]: Publish comfyui-desktop to github releases #455

jo-chemla opened this issue Dec 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jo-chemla
Copy link

jo-chemla commented Dec 9, 2024

Prerequisites

  • I have searched the existing issues and checked the recent builds/commits
  • I have read the documentation and this feature is not already available
  • This is a single feature request (not multiple features combined)

Problem StatementIt would be great to have ComfyUI available as a winget-pkgs ( https://github.com/microsoft/winget-pkgs ) package, so it could simply be installed on windows via winget install ComfyUI. This would involve publishing github releases as other archive formats like standard zip.

Proposed SolutionOnce releases are available as msi/exe or zip, one can even setup a winget-releaserv2 github action workflow so every new github release gets automatically pushed to the winget-pkgs repo.

Potential workflow

  1. PR just opened with ComfyUI-desktop here: New package: Comfy.ComfyUI-Desktop version 0.3.18 microsoft/winget-pkgs#194595 following desktop release
  2. The URL to the installer is a vanity url, although winget-pkgs team expects future-proof urls https://download.comfy.org/windows/nsis/x64
  3. Storing the installers or executables as github releases for Comfy-Desktop, the same way it is done for ComfyUI here ( https://github.com/comfyanonymous/ComfyUI/releases/tag/v0.3.7 ) would allow for winget release

Impact LevelHigh (Major improvement)

Alternatives ConsideredIssue on the comfyanonymous/ComfyUI repo here comfyanonymous/ComfyUI#5310

Additional informationNo response

┆Issue is synchronized with this Notion page by Unito

@jo-chemla jo-chemla added the enhancement New feature or request label Dec 9, 2024
@jo-chemla jo-chemla changed the title [Feature Request]: Publish to githubv releases [Feature Request]: Publish comfyui-desktop to github releases Dec 9, 2024
@robinjhuang
Copy link
Member

@jo-chemla Does it need to be published on Github releases? In your PR you are using the download.comfy.org URL, which will always point to the latest release. Also, does it need to be zip? We use the NSIS installer right now, not Squirrel for Windows.

We can also publish Github releases, but we use ToDesktop as our build system right now for code-signing so will require a bit more work to include the builds here as well.

@jo-chemla
Copy link
Author

Thanks for getting back!

The PR has been withheld by winget-pkgs team because this permanent download url returns an installer which might have a hash that differs from the hash of the installer of when version that was submitted/PR'ed. Hence it is easier to have one package url per version if the installer, and a lot of winget-pkgs rely on github releases.

Github releases do not need to be signed tor the winget team to accept the package to my understanding, so maybe you could just use the winget-releaser v2 action and it should be good to go.

Finally regarding type of installer, as long as this is not a scripted application with bat, it can be a zip with portable executable, or installer exe or msi, there are lots of different types of packages and the choice is up to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants