Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - Are you accepting PR ? Are there contributing guidelines somewhere ? #300

Open
Nevysha opened this issue Nov 11, 2024 · 1 comment

Comments

@Nevysha
Copy link

Nevysha commented Nov 11, 2024

Hello,

I'm considering writting a superset of your litegraph fork to be usable and well integrated into React. I'll oc do this in a dedicated repo.

Anyway as I'm playing with your lib I'm encountering various small things that I could fix with some small PR.

ie some type declaration that does not make sense regarding the jsdoc of said function :

 /**
    * Creates a new instance of LGraphCanvas.
    * @param canvas The canvas HTML element (or its id) to use, or null / undefined to leave blank.
    * @param graph The graph that owns this canvas.
    * @param options
    */
    constructor(canvas: HTMLCanvasElement, graph: LGraph, options?: LGraphCanvas["options"]);

If you pass a string to this constructor it may throw error on strict eslint config.

I'll be happy to contribute. Can you point me the contribution guildline ?

Regards,
Nevysha

@webfiltered
Copy link
Collaborator

Hey there. So there are some reasonably epic-sized PRs in play at the moment. If you're planning a hard fork, I'd wait for the pointer API to land (fingers crossed). Shortly after that happens, the plan is to autoformat the entire entire repo.

PRs are welcome! Contributing guide has not yet been written - current version was inherited and (just checked) only contains outdated info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants