You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm considering writting a superset of your litegraph fork to be usable and well integrated into React. I'll oc do this in a dedicated repo.
Anyway as I'm playing with your lib I'm encountering various small things that I could fix with some small PR.
ie some type declaration that does not make sense regarding the jsdoc of said function :
/**
* Creates a new instance of LGraphCanvas.
* @param canvas The canvas HTML element (or its id) to use, or null / undefined to leave blank.
* @param graph The graph that owns this canvas.
* @param options
*/
constructor(canvas: HTMLCanvasElement, graph: LGraph, options?: LGraphCanvas["options"]);
If you pass a string to this constructor it may throw error on strict eslint config.
I'll be happy to contribute. Can you point me the contribution guildline ?
Regards,
Nevysha
The text was updated successfully, but these errors were encountered:
Hey there. So there are some reasonably epic-sized PRs in play at the moment. If you're planning a hard fork, I'd wait for the pointer API to land (fingers crossed). Shortly after that happens, the plan is to autoformat the entire entire repo.
PRs are welcome! Contributing guide has not yet been written - current version was inherited and (just checked) only contains outdated info.
Hello,
I'm considering writting a superset of your litegraph fork to be usable and well integrated into React. I'll oc do this in a dedicated repo.
Anyway as I'm playing with your lib I'm encountering various small things that I could fix with some small PR.
ie some type declaration that does not make sense regarding the jsdoc of said function :
If you pass a string to this constructor it may throw error on strict eslint config.
I'll be happy to contribute. Can you point me the contribution guildline ?
Regards,
Nevysha
The text was updated successfully, but these errors were encountered: