Optimize commitment_core::get_commitments_created_between to avoid scanning AllCommitmentIds

[1nonlypiece]

📌 Description

commitment_core::get_commitments_created_between (line ~735) answers time-range
analytics queries by scanning the DataKey::AllCommitmentIds vector, which grows
unbounded with every create_commitment. As the protocol scales, this linear scan
plus per-id storage reads becomes a costly, potentially limit-exceeding operation.

This issue introduces a time-bucketed index so range queries are bounded.

🎯 Requirements and Context

• Maintain a time-bucketed index (e.g. per-day buckets of commitment IDs) updated on create_commitment.
• get_commitments_created_between must read only the relevant buckets, not the global list.
• Results must be identical to the current full-scan implementation (add an equivalence test).
• Index writes must not regress create_commitment correctness or its reentrancy/fee paths.

🛠️ Suggested Execution

1. Fork the repo and create a branch

git checkout -b perf/core-time-bucket-index

2. Implement changes

• Add the bucketed index key and update create_commitment + get_commitments_created_between in contracts/commitment_core/src/lib.rs with /// docs.
• Record before/after costs in benchmarks/.

3. Test and commit

• Extend contracts/commitment_core/src/tests.rs and benchmarks.rs.
• Run: cargo test --target wasm32v1-none --release
• Edge cases: empty range, single-bucket range, multi-bucket range, boundary timestamps, equivalence vs full scan.

Example commit message

perf: time-bucketed index for commitment range queries

✅ Guidelines

• Minimum 95% test coverage on the indexed paths.
• Document the equivalence guarantee and measured savings.
• Timeframe: 96 hours.

🏷️ Labels

type-performance · area-contracts · MAYBE REWARDED · GRANTFOX OSS · OFFICIAL CAMPAIGN

💬 Community & Support

• Join the CommitLabs contributor Discord to coordinate and get unblocked fast: https://discord.gg/WV7tdYkJk
• Introduce yourself before starting to avoid duplicate work.
• Maintainers triage actively and review fast.

[dangelo352]

I'll take this one and add the time-bucketed commitment index plus equivalence/boundary coverage.

[grantfox-oss]

🦊 GrantFox — @dangelo352 has been assigned to this issue as part of the Official Campaign | FWC26 campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #497)
2. Your PR will be reviewed by the Commitlabs-Org maintainers

Good luck! Track your progress on GrantFox.

[1nonlypiece]

You're in! This one's yours now. For support, questions, or just to chat with other contributors, join us on Discord: https://discord.gg/jzgTqSbZX