Skip to content

Commit 5dc3410

Browse files
committed
Refactor Dapr sidecar configuration to simplify AppId handling and remove redundant checks
1 parent 1afa00b commit 5dc3410

File tree

1 file changed

+0
-29
lines changed

1 file changed

+0
-29
lines changed

src/CommunityToolkit.Aspire.Hosting.Dapr/IDistributedApplicationComponentBuilderExtensions.cs

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -63,38 +63,9 @@ public static IResourceBuilder<T> WithDaprSidecar<T>(this IResourceBuilder<T> bu
6363
});
6464

6565

66-
var serviceId = builder.Resource.Name;
6766

6867
configureSidecar(sidecarBuilder);
6968

70-
if(sidecarBuilder.Resource.TryGetAnnotationsOfType<DaprSidecarOptionsAnnotation>(out var optionsAnnotations) &&
71-
optionsAnnotations.LastOrDefault() is { } optionsAnnotation)
72-
{
73-
// If no AppId was specified, use the resource name.
74-
if (string.IsNullOrEmpty(optionsAnnotation.Options.AppId))
75-
{
76-
sidecarBuilder.WithOptions(new DaprSidecarOptions
77-
{
78-
AppId = serviceId,
79-
Config = optionsAnnotation.Options.Config,
80-
EnableApiLogging = optionsAnnotation.Options.EnableApiLogging,
81-
LogLevel = optionsAnnotation.Options.LogLevel,
82-
EnableProfiling = optionsAnnotation.Options.EnableProfiling,
83-
MetricsPort = optionsAnnotation.Options.MetricsPort,
84-
DaprHttpPort = optionsAnnotation.Options.DaprHttpPort,
85-
DaprGrpcPort = optionsAnnotation.Options.DaprGrpcPort,
86-
});
87-
}
88-
}
89-
else
90-
{
91-
// No options were specified, so set a default AppId.
92-
sidecarBuilder.WithOptions(new DaprSidecarOptions
93-
{
94-
AppId = serviceId,
95-
});
96-
}
97-
9869

9970
return builder.WithAnnotation(new DaprSidecarAnnotation(sidecarBuilder.Resource));
10071
}

0 commit comments

Comments
 (0)