Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegmentedItem should expose ContentHolder's Margin #522

Open
3 of 24 tasks
Lightczx opened this issue Sep 26, 2024 · 0 comments
Open
3 of 24 tasks

SegmentedItem should expose ContentHolder's Margin #522

Lightczx opened this issue Sep 26, 2024 · 0 comments

Comments

@Lightczx
Copy link

Lightczx commented Sep 26, 2024

Describe the bug

As DefaultSegmentedItemStyle

<!-- Content -->
<Grid x:Name="ContentHolder"
Margin="11,0,11,0"
HorizontalAlignment="Center"
VerticalAlignment="Stretch"
ColumnSpacing="8">

and PivotSegmentedItemStyle

<Grid x:Name="ContentHolder"
Margin="12,0,12,0"
HorizontalAlignment="Center"
VerticalAlignment="Stretch"
ColumnSpacing="8">

the ContentHolder hardcoded it's Margin, but

<!-- Content -->
<Grid x:Name="ContentHolder"
Margin="{TemplateBinding Padding}"
HorizontalAlignment="Center"
VerticalAlignment="Stretch"
ColumnSpacing="8">

ButtonSegmentedItemStyle using Padding property which come from ButtonItemPadding resource

Expected behavior

Add a new Thickness resource like DefaultSegmentedItemContentPadding, so that we can alter the content padding easily.

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

2022

Visual Studio Build Number

No response

Device form factor

Desktop

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

@Lightczx Lightczx changed the title SegmentedItem using DefaultSegmentedItemStyle should expose ContentHolder's Margin SegmentedItem should expose ContentHolder's Margin Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant