Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextToolbar contains option "Strikethrough" twice though one is actually option "italic" #3540

Closed
1 of 2 tasks
marcelwgn opened this issue Oct 21, 2020 · 4 comments
Closed
1 of 2 tasks
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior needs triage 🔍 sample app 🖼
Milestone

Comments

@marcelwgn
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.

The TextToolbar in the sample app has two buttons that announce themselves as "strikethrough", though one of them is actually the option "italic".

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

  • Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)

Steps to reproduce the behavior:

  1. Open TextToolbar page in sample app
  2. Hover over 2nd and 5th button
  3. Observe that both say "strikethrough" though the first of the two actually is the italic button

Expected behavior

A clear and concise description of what you expected to happen.
2nd button should have "Italic ctrl+i" as tooltip text.

Screenshots

Environment

NuGet Package(s): 

Package Version(s): 

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [x] Insider Build (build number: 20236)

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [ ] Insider Build (xxxxx)

Device form factor:
- [x] Desktop
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 (version: )
- [ ] 2019 (version: ) 
- [ ] 2019 Preview (version: )

Additional context

@marcelwgn marcelwgn added the bug 🐛 An unexpected issue that highlights incorrect behavior label Oct 21, 2020
@ghost ghost added the needs triage 🔍 label Oct 21, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

Hello chingucoding, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Kyaa-dost
Copy link
Contributor

@chingucoding I was able to reproduce all the issues you opened today #3539 #3538 #3537 Kudos to you for finding and highlighting these issues 🙌 If you want to work on any or all the issues feel free to create a single PR and we can merge them all together. Let us know if it's possible.

@Kyaa-dost Kyaa-dost added this to the 7.0 milestone Oct 22, 2020
@marcelwgn
Copy link
Contributor Author

Sure, I'll work on all four of them.

@marcelwgn
Copy link
Contributor Author

I can't repro this specific issue with the text in debug builds of the sample app, so I think this was fixed. Or are there any differences between the store version and the debug builds of the app? (Closing this issue in the meantime)

@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior needs triage 🔍 sample app 🖼
Projects
None yet
Development

No branches or pull requests

2 participants