Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: DynamioRIO client crashes/behaves unpredictably on multithreaded programs. #14

Open
Chadderz121 opened this issue Feb 27, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Chadderz121
Copy link
Collaborator

The current DynamoRIO client is not thread-safe because it uses global variables (e.g. stack_index) and because the counters are not thread private and not atomically updated. For these reasons, multithreaded workloads almost always cause either crashes or nonesense output from optiwise count. At the very least we should avoid crashing by e.g. only sampling the main thread to address the bug, but ideally as an enhancement we should fully support multithreaded workloads.

@Chadderz121 Chadderz121 added bug Something isn't working enhancement New feature or request labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant