Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional improvements to Json IO #235

Open
PDoakORNL opened this issue Dec 15, 2020 · 0 comments
Open

Additional improvements to Json IO #235

PDoakORNL opened this issue Dec 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@PDoakORNL
Copy link
Contributor

With regards to the life cycle of the object, RAII could be better.
If we're going to throw for a bad file and the purpose of close file is it to prepare for another open...
It seems be better to just have the file as a constructor argument and do no "reseting" closing the file in the destructor.

With regards to repeated tags, that seems like invalid input and an exception should be thrown.

@PDoakORNL PDoakORNL added the enhancement New feature or request label Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant