-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize Application #16
Labels
Comments
I changed around the storage methods in the past version to use S3 api instead of flat-files. While that doesn't directly effect the generalization of the application away from CSH specific practices it does allow for a more portable/agnostic setup environment. |
liam-middlebrook
added a commit
that referenced
this issue
Dec 29, 2017
Now where instances of the string literal "reedphoto" would exist have been replaced with references to a constant DEFAULT_THUMBNAIL_NAME Effort Towards Bug #16
liam-middlebrook
added a commit
that referenced
this issue
Dec 31, 2017
Because Gallery used to use physically backed files and was located at `/gallery-data/root/root` Gallery instances had a root directory with an ID of 3. This created a need to artificially limit viewing of directories to require a directory ID of at least 3. Commit 4682ce6 adds support for S3 and eliminates the need for the root directory to have a ID of 3 workaround. This change cleans up that cruft to ease in the setup of future Gallery instances. Effort Towards Bug #16
liam-middlebrook
added a commit
that referenced
this issue
Dec 31, 2017
This allows for Gallery to bootstrap itself up on a clean database without manual intervention. In addition Gallery will attempt to upload the default thumbnail to S3. Effort Towards Bug #16
liam-middlebrook
added a commit
that referenced
this issue
Jan 2, 2018
Because Gallery used to use physically backed files and was located at `/gallery-data/root/root` Gallery instances had a root directory with an ID of 3. This created a need to artificially limit viewing of directories to require a directory ID of at least 3. Commit 4682ce6 adds support for S3 and eliminates the need for the root directory to have a ID of 3 workaround. This change cleans up that cruft to ease in the setup of future Gallery instances. Effort Towards Bug #16
liam-middlebrook
added a commit
that referenced
this issue
Jan 2, 2018
This allows for Gallery to bootstrap itself up on a clean database without manual intervention. In addition Gallery will attempt to upload the default thumbnail to S3. Effort Towards Bug #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A bit of work has already been done to generalize the application so that it won't be specific to a singular setup. More effort should be done on this in order to truly support setups outside of CSH.
The text was updated successfully, but these errors were encountered: