Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail Images With Nonexistent Sources Are Incorrectly Sized #80

Closed
adamhb123 opened this issue Aug 9, 2021 · 1 comment · Fixed by #93 · May be fixed by #81
Closed

Thumbnail Images With Nonexistent Sources Are Incorrectly Sized #80

adamhb123 opened this issue Aug 9, 2021 · 1 comment · Fixed by #93 · May be fixed by #81

Comments

@adamhb123
Copy link
Member

If a thumbnail's image source is unavailable, the element's height is far smaller than the others, throwing off grid sizing and element positioning.

I have a pure-CSS solution to this that may or may not be satisfactory, and will submit a PR soon.

Example: Visual example of issue

adamhb123 added a commit to adamhb123/gallery that referenced this issue Aug 9, 2021
Adds some CSS to ensure that thumbnail images with bad sources are correctly sized
Resolves ComputerScienceHouse#80
adamhb123 added a commit to adamhb123/gallery that referenced this issue Aug 9, 2021
Adds some HTML and CSS to ensure that thumbnail images with bad sources
are correctly sized. Resolves ComputerScienceHouse#80.
@jabbate19
Copy link
Contributor

It appears what is happening is Gallery is making a call to S3 for the photo, and S3 is giving a 404 (likely deleted photo). The request needs to be checked beforehand and if it gets a 404, call the refresh

mxmeinhold added a commit that referenced this issue May 17, 2022
Fix: Gallery Thumbnails Failing to Re-Assign
---
So when a file that was the thumbnail of a directory was deleted, the directory thumbnail didn't update and caused a 404 when Gallery reached out to S3/Local Storage to get it again. This makes it detect a non-ok status code and reset the thumbnail for that directory.

Fixes #65
Fixes #67
Fixes #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants