Fix GetSettings - Ignore nameless values & trim values.#11
Conversation
|
Added a commit because I found a similar issue with getting current values before setting BIOS settings. |
|
Thanks for catching this and apologies for the very long delay. A clean merge wasn't possible because the script was renamed during the v2 modernization (HP/Manage-HPBiosSettings.ps1 > Manage-HPBiosSettings-WMI.ps1), but your diagnosis was right and the bug was still present in v2.3.0. The fix is included in v2.3.1 (commit 4c3688e). Once I started applying it I noticed the same asterisk-prefix-with-leading-whitespace pattern appeared in a few more places. HP Sure Admin detection in both Manage-HPBiosSettings-WMI.ps1 and Manage-HPBiosPasswords-WMI.ps1, plus the enumeration parsing in the new Manage-HPBiosSettings-HPCMSL.ps1 — so the same trim-at-source approach was extended to those sites too. You're credited by name in each affected script's changelog entry. Closing this PR as incorporated. |
Hello,
2 things in this pull request: