Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not retrieve PCI address from lspci #18

Closed
BavYeti opened this issue Sep 11, 2020 · 9 comments
Closed

Could not retrieve PCI address from lspci #18

BavYeti opened this issue Sep 11, 2020 · 9 comments
Labels
needs testing Suggested change seems reasonable but needs to be tested

Comments

@BavYeti
Copy link
Contributor

BavYeti commented Sep 11, 2020

I guess the output format of lspci verbose changed and the script stops with

Could not retrieve PCI address from lspci

man lspci suggest to use the -m flag for machine readable output

@BavYeti
Copy link
Contributor Author

BavYeti commented Sep 11, 2020

Sorry should have read through all issues #14 mentions this already. Anyway I think my patch is backwards compatible and future proof.

Tested on Ubuntu 20.04

@Confusingboat
Copy link
Owner

Confusingboat commented Sep 11, 2020

I'll be happy to merge in #19 if someone can confirm it also works with 18.04

@Confusingboat Confusingboat added the needs testing Suggested change seems reasonable but needs to be tested label Sep 11, 2020
@eyeofmaat
Copy link

I need to run this on a R420 soon. I have 2 of them to do.
If you want me to do something specific, let me know.

@jayeshgarg
Copy link

jayeshgarg commented Nov 8, 2020

+1
tested patch with H310 MM on Ubuntu 20.04.1
Few pointers that may help others(specially dummies like me) using this script and patch

  1. Run from pen drive or any other drive not connected via RAID controller(H310)
  2. Include this patch (https://github.com/Confusingboat/flash-it/pull/19/files)
  3. Download the sample CFG file as well and remove ".example" from it
  4. May require manual installation of 7z, Git, Libncurses5(all variants), etc

@Confusingboat
Copy link
Owner

Sorry for being so slow with this guys.

@eyeofmaat I just want to make sure the script works without manual steps on both 18.04 and 20.04; perhaps you could test the patch with one R420 each on 18.04 and 20.04? That would be awesome.

@jayeshgarg fyi downloading the sample CFG file shouldn't be necessary (check out the script and you'll see its reference is commented out), I've just left it in the repository as reference. Also, if there are manual package installation steps required with Ubuntu 20.04, let's verify which ones are missing and open another issue with those listed so we can get that piece automated in a manner that's backwards compatible with 18.04.

@BavYeti
Copy link
Contributor Author

BavYeti commented Nov 12, 2020

@Confusingboat fyi I tested it on a R320 #17 with 20.04 #16 see PR for the Readme

@eyeofmaat
Copy link

I have a live install of 18.04.5 (LTS i think) on a USB ready to try this, but I dont know github very well. I dont know how to bring in the patch. I can see the 2 lines (147/148) that were changed, so I can manually edit it in VIM unless you can link me some instructions to include it automatically?

@BavYeti
Copy link
Contributor Author

BavYeti commented Nov 13, 2020

@eyeofmaat you basically clone the patched fork I made. Link is in my PR #19 or you go directly to https://github.com/BavYeti/flash-it

@yetkinergun
Copy link

came here to say I also used this branch after running into issues on master - can confirm it worked well on my R720xd with H310MM, using Ubuntu 20 Live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Suggested change seems reasonable but needs to be tested
Projects
None yet
Development

No branches or pull requests

5 participants