Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove reverts from compressor #482

Open
6 tasks
Tabaie opened this issue Dec 24, 2024 · 0 comments
Open
6 tasks

Refactor: Remove reverts from compressor #482

Tabaie opened this issue Dec 24, 2024 · 0 comments
Assignees
Labels
Data compressor go Pull requests that update Go code good first issue Good for newcomers TechDebt Technical Debt

Comments

@Tabaie
Copy link
Contributor

Tabaie commented Dec 24, 2024

Description

In accordance with @ivokub's feedback on #367, change the compressor's flow into one that writes on a "scratch" and in case of success copies it into the current state. This would replace the current strategy of optimistically attempting to compress and reverting if something went wrong.

Motivation

The fact that there are more ways of going wrong than going right (there are many control paths leading to a revert) has lead to complex code involving many goto-labels. The pessimistic strategy will result in smaller, more readable code.

@gbotrel thoughts?

Tasks

  • Medium-level task that needs to be implemented for this feature request to be considered complete.

Acceptance criteria

  • List tests that need to be implemented or checks to consider this task completed.

Risks

  • These are risks that may prevent completion of the task as well as areas to pay special attention to

Remember to

  • Add the documentation label in case there is an impact on the documentation
  • Add priority and team labels
  • Add Task for updating the Runbook or adding/updating existing metrics and alerts.
@Tabaie Tabaie self-assigned this Dec 24, 2024
@Tabaie Tabaie added good first issue Good for newcomers TechDebt Technical Debt Data compressor go Pull requests that update Go code labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data compressor go Pull requests that update Go code good first issue Good for newcomers TechDebt Technical Debt
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant