Fix SoundCloud downloading by switching to api-v2. ffmpeg now seems to be required.

Author: stefansundin

app.rb

@@ -682,25 +682,21 @@
   end
 
   response = Soundcloud.get("/resolve", query: { url: "https://soundcloud.com/#{username}" })
-  if response.code == 302
-    uri = Addressable::URI.parse(response.json["location"])
-    return [404, "URL does not resolve to a user."] if !uri.path.start_with?("/users/")
-    id = uri.path[/\d+/]
+  if response.code == 200
+    data = response.json
+    data = data["user"] if data.has_key?("user")
+    return [404, "Can't identify the user."] if data["kind"] != "user"
   elsif response.code == 404 && username.numeric?
     response = Soundcloud.get("/users/#{username}")
-    return [response.code, "Can't find a user with that id. Sorry."] if response.code == 404
+    return [response.code, "Can't find a user with that id. Sorry."] if response.code == 400 || response.code == 404
     raise(SoundcloudError, response) if !response.success?
-    id = response.json["id"]
+    data = response.json
   elsif response.code == 404
     return [response.code, "Can't find a user with that name. Sorry."]
   else
     raise(SoundcloudError, response)
   end
 
-  response = Soundcloud.get("/users/#{id}")
-  raise(SoundcloudError, response) if !response.success?
-  data = response.json
-
   redirect Addressable::URI.new(path: "/soundcloud/#{data["id"]}/#{data["permalink"]}").normalize.to_s
 end
 
@@ -709,25 +705,19 @@
   url = "https://#{url}" if !url.start_with?("http:", "https:")
   response = Soundcloud.get("/resolve", query: { url: url })
   return [response.code, "URL does not resolve."] if response.code == 404
-  raise(SoundcloudError, response) if response.code != 302
-  uri = Addressable::URI.parse(response.json["location"])
-  return [404, "URL does not resolve to a track."] if !uri.path.start_with?("/tracks/")
-  response = Soundcloud.get("#{uri.path}/stream")
-  raise(SoundcloudError, response) if response.code != 302
-  media_url = response.json["location"]
+  raise(SoundcloudError, response) if response.code != 200
 
-  if env["HTTP_ACCEPT"] == "application/json"
-    response = Soundcloud.get("#{uri.path}")
-    content_type :json
-    data = response.json
-    created_at = Time.parse(data["created_at"])
-    return {
-      url: media_url,
-      filename: "#{created_at.to_date} - #{data["title"]}.mp3".to_filename,
-    }.to_json
-  end
+  data = response.json
+  return [404, "URL does not resolve to a track."] if data["kind"] != "track"
 
-  redirect media_url
+  data_uri = Addressable::URI.parse(data["media"]["transcodings"][0]["url"])
+  response = Soundcloud.get(data_uri.path)
+  raise(SoundcloudError, response) if response.code != 200
+
+  url = response.json["url"]
+  fn = "#{Date.parse(data["created_at"])} - #{data["title"]}.mp3".to_filename
+
+  "ffmpeg -i '#{url}' -acodec copy '#{fn}'"
 end
 
 get %r{/soundcloud/(?<id>\d+)/(?<username>.+)} do |id, username|
@@ -737,7 +727,7 @@
   return [404, "That user no longer exist."] if response.code == 500 && response.body == '{"error":"Match failed"}'
   raise(SoundcloudError, response) if !response.success?
 
-  @data = response.json
+  @data = response.json["collection"]
   @username = @data[0]["user"]["permalink"] rescue CGI.unescape(username)
   @user = @data[0]["user"]["username"] rescue CGI.unescape(username)
 

app/soundcloud.rb

@@ -4,7 +4,7 @@
 class SoundcloudError < HTTPError; end
 
 class Soundcloud < HTTP
-  BASE_URL = "https://api.soundcloud.com"
+  BASE_URL = "https://api-v2.soundcloud.com"
   PARAMS = "client_id=#{ENV["SOUNDCLOUD_CLIENT_ID"]}"
   ERROR_CLASS = SoundcloudError
 end

views/index.erb

@@ -136,9 +136,7 @@
       <div class="input-group-append">
         <button type="button" class="btn btn-secondary dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"></button>
         <div class="dropdown-menu dropdown-menu-right">
-          <a class="dropdown-item" data-download>Open track</a>
-          <a class="dropdown-item" data-download download>Download track</a>
-          <a class="dropdown-item" data-download-filename>Download track with nice filename</a>
+          <a class="dropdown-item" data-download>Get download command</a>
         </div>
         <input class="btn btn-primary" type="submit" value="Get RSS Feed">
       </div>

views/soundcloud_feed.erb

@@ -23,7 +23,6 @@
 <%= track["description"].linkify.to_paragraphs.esc %>
 
 &lt;p>&lt;a href="<%= request.root_url %>/soundcloud/download<%= Addressable::URI.new(query: "url=#{track["permalink_url"]}").normalize.to_s %>">Download track&lt;/a>&lt;/p>
-&lt;p>&lt;a href="<%= request.root_url %>/<%= Addressable::URI.new(query: "download=#{track["permalink_url"]}").normalize.to_s %>">Download track with nice filename&lt;/a>&lt;/p>
     </content>
   </entry>
 <%- end -%>