fix(plugins): make example plugins compile on edition 2024

Isolate the example crates with an empty [workspace] table so they
build outside the CLI workspace. Use unsafe extern blocks and
#[unsafe(no_mangle)] so hello-world and code-stats compile on
Rust 1.98 / edition 2024 after dropping wee_alloc.

Co-authored-by: Mathis <echobt@users.noreply.github.com>

Author: cursoragent

docs/customization/plugins/getting-started.md

@@ -119,7 +119,7 @@ Replace `src/lib.rs` with:
 
 // Host function imports
 #[link(wasm_import_module = "cortex")]
-extern "C" {
+unsafe extern "C" {
     /// Log a message at the specified level
     /// level: 0=trace, 1=debug, 2=info, 3=warn, 4=error
     fn log(level: i32, msg_ptr: i32, msg_len: i32);
@@ -146,14 +146,14 @@ fn log_debug(msg: &str) {
 // ============================================================================
 
 /// Called when the plugin is initialized
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn init() -> i32 {
     log_info("Hello Plugin initialized!");
     0 // Return 0 for success
 }
 
 /// Called when the plugin is shutting down
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn shutdown() -> i32 {
     log_info("Hello Plugin shutting down");
     0
@@ -165,7 +165,7 @@ pub extern "C" fn shutdown() -> i32 {
 
 /// Handler for the /hello command
 /// Function name format: cmd_<command_name_with_underscores>
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn cmd_hello() -> i32 {
     log_info("Hello, World!");
     0
@@ -284,7 +284,7 @@ fn log_debug(msg: &str) {
     }
 }
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn cmd_hello() -> i32 {
     log_debug("cmd_hello called");
     // ... rest of function
@@ -393,9 +393,9 @@ timeout_ms = 30000  # Longer timeout for debugging
    - Rust: `fn cmd_my_command()`
    - Replace hyphens with underscores
 
-2. Check `#[no_mangle]` attribute:
+2. Check `#[unsafe(no_mangle)]` attribute:
    ```rust
-   #[no_mangle]
+   #[unsafe(no_mangle)]
    pub extern "C" fn cmd_hello() -> i32 {
        // ...
    }
@@ -467,7 +467,7 @@ timeout_ms = 30000  # Longer timeout for debugging
 **Solutions**:
 1. Log at the start and end of each exported function so a panic is easier to locate:
    ```rust
-   #[no_mangle]
+   #[unsafe(no_mangle)]
    pub extern "C" fn cmd_hello() -> i32 {
        log_debug("Starting cmd_hello");
        // Your code here

examples/plugins/code-stats/Cargo.toml

@@ -11,6 +11,9 @@ license = "Apache-2.0"
 [lib]
 crate-type = ["cdylib"]
 
+# Standalone package: not a workspace member of the Cortex CLI tree.
+[workspace]
+
 [profile.release]
 opt-level = "s"
 lto = true

examples/plugins/code-stats/src/lib.rs

@@ -15,7 +15,7 @@ use std::sync::atomic::{AtomicU64, Ordering};
 // ============================================================================
 
 #[link(wasm_import_module = "cortex")]
-extern "C" {
+unsafe extern "C" {
     /// Log a message at the specified level.
     /// level: 0=trace, 1=debug, 2=info, 3=warn, 4=error
     fn log(level: i32, msg_ptr: i32, msg_len: i32);
@@ -273,7 +273,7 @@ fn record_file_deleted(lines: u64) {
 /// # Returns
 /// - `0` on success
 /// - Non-zero on failure
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn init() -> i32 {
     log_info("Code Stats plugin initializing...");
 
@@ -303,7 +303,7 @@ pub extern "C" fn init() -> i32 {
 /// # Returns
 /// - `0` on success
 /// - Non-zero on failure
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn shutdown() -> i32 {
     log_info("Code Stats plugin shutting down");
 
@@ -330,7 +330,7 @@ pub extern "C" fn shutdown() -> i32 {
 /// # Returns
 /// - `0` on success
 /// - Non-zero on failure
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn cmd_stats() -> i32 {
     log_debug("Stats command executed");
 
@@ -354,7 +354,7 @@ pub extern "C" fn cmd_stats() -> i32 {
 /// # Returns
 /// - `0` on success
 /// - Non-zero on failure
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn cmd_stats_reset() -> i32 {
     log_debug("Stats reset command executed");
 
@@ -378,7 +378,7 @@ pub extern "C" fn cmd_stats_reset() -> i32 {
 /// # Returns
 /// - `0` on success
 /// - Non-zero on failure
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn cmd_stats_export() -> i32 {
     log_debug("Stats export command executed");
 
@@ -412,7 +412,7 @@ pub extern "C" fn cmd_stats_export() -> i32 {
 /// - `0` to continue normally
 /// - `1` to skip further processing
 /// - `2` to abort the operation chain
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn hook_file_operation_after() -> i32 {
     log_debug("File operation hook triggered");
 
@@ -446,7 +446,7 @@ pub extern "C" fn hook_file_operation_after() -> i32 {
 /// - `0` to continue normally
 /// - `1` to skip further processing
 /// - `2` to abort
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn hook_session_end() -> i32 {
     log_info("Session end hook triggered - saving statistics");
 
@@ -469,7 +469,7 @@ pub extern "C" fn hook_session_end() -> i32 {
 /// - `0` to continue normally
 /// - `1` to skip
 /// - `2` to abort
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn hook_widget_register() -> i32 {
     log_debug("Widget registration hook triggered");
 
@@ -493,7 +493,7 @@ pub extern "C" fn hook_widget_register() -> i32 {
 /// # Returns
 /// - `0` on success
 /// - Non-zero on failure
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn widget_render_code_stats() -> i32 {
     // Get compact stats for status bar display
     let added = LINES_ADDED.load(Ordering::Relaxed);
@@ -519,7 +519,7 @@ pub extern "C" fn widget_render_code_stats() -> i32 {
 ///
 /// # Returns
 /// - `0` on success
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn api_record_file_created() -> i32 {
     // In real implementation, read line count from shared buffer
     let lines: u64 = 0; // Placeholder - would be read from buffer
@@ -536,7 +536,7 @@ pub extern "C" fn api_record_file_created() -> i32 {
 ///
 /// # Returns
 /// - `0` on success
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn api_record_file_deleted() -> i32 {
     // In real implementation, read line count from shared buffer
     let lines: u64 = 0; // Placeholder - would be read from buffer
@@ -551,7 +551,7 @@ pub extern "C" fn api_record_file_deleted() -> i32 {
 /// # Returns
 /// - Length of JSON string on success
 /// - Negative value on failure
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn api_get_stats_json() -> i64 {
     let json = get_stats_json();
     json.len() as i64

examples/plugins/hello-world/Cargo.toml

@@ -11,6 +11,9 @@ license = "Apache-2.0"
 [lib]
 crate-type = ["cdylib"]
 
+# Standalone package: not a workspace member of the Cortex CLI tree.
+[workspace]
+
 [profile.release]
 opt-level = "s"
 lto = true

examples/plugins/hello-world/src/lib.rs

@@ -12,7 +12,7 @@
 // ============================================================================
 
 #[link(wasm_import_module = "cortex")]
-extern "C" {
+unsafe extern "C" {
     /// Log a message at the specified level.
     /// level: 0=trace, 1=debug, 2=info, 3=warn, 4=error
     fn log(level: i32, msg_ptr: i32, msg_len: i32);
@@ -119,7 +119,7 @@ fn show_notification(level: ToastLevel, message: &str, duration_ms: i32) {
 /// # Returns
 /// - `0` on success
 /// - Non-zero on failure (plugin will not be activated)
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn init() -> i32 {
     log_info("Hello World plugin initializing...");
 
@@ -146,7 +146,7 @@ pub extern "C" fn init() -> i32 {
 /// # Returns
 /// - `0` on success
 /// - Non-zero on failure (logged but doesn't prevent unloading)
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn shutdown() -> i32 {
     log_info("Hello World plugin shutting down");
     0 // Success
@@ -166,7 +166,7 @@ pub extern "C" fn shutdown() -> i32 {
 /// # Returns
 /// - `0` on success
 /// - Non-zero on failure
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn cmd_hello() -> i32 {
     log_info("Hello command executed");
 
@@ -201,7 +201,7 @@ pub extern "C" fn cmd_hello() -> i32 {
 /// - `0` to continue with tool execution
 /// - `1` to skip this tool execution
 /// - `2` to abort the entire operation
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn hook_tool_execute_before() -> i32 {
     log_debug("Tool execution intercepted by hello-world plugin");
 

src/cortex-cli/src/plugin_cmd.rs

@@ -86,7 +86,7 @@ const RUST_TEMPLATE: &str = r#"//! {{plugin_name}} - A Cortex plugin
 // ============================================================================
 
 #[link(wasm_import_module = "cortex")]
-extern "C" {
+unsafe extern "C" {
     /// Log a message at the specified level.
     /// level: 0=trace, 1=debug, 2=info, 3=warn, 4=error
     fn log(level: i32, msg_ptr: i32, msg_len: i32);
@@ -120,14 +120,14 @@ fn log_info(msg: &str) { log_message(2, msg); }
 // ============================================================================
 
 /// Called when the plugin is initialized.
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn init() -> i32 {
     log_info("{{plugin_name}} initialized");
     0 // Return 0 for success
 }
 
 /// Called when the plugin is shutting down.
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn shutdown() -> i32 {
     log_info("{{plugin_name}} shutting down");
     0
@@ -138,7 +138,7 @@ pub extern "C" fn shutdown() -> i32 {
 // ============================================================================
 
 /// Handler for the /{{command_name}} command.
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn cmd_{{command_name_snake}}() -> i32 {
     log_info("{{command_name}} command executed");
     0
@@ -164,7 +164,7 @@ const RUST_ADVANCED_TEMPLATE: &str = r#"//! {{plugin_name}} - Advanced Cortex Pl
 // ============================================================================
 
 #[link(wasm_import_module = "cortex")]
-extern "C" {
+unsafe extern "C" {
     fn log(level: i32, msg_ptr: i32, msg_len: i32);
     fn get_context() -> i64;
     fn register_widget(region: i32, widget_type_ptr: i32, widget_type_len: i32) -> i32;
@@ -254,7 +254,7 @@ fn show_notification(level: ToastLevel, message: &str, duration_ms: i32) {
 // Plugin lifecycle
 // ============================================================================
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn init() -> i32 {
     log_info("{{plugin_name}} initializing...");
     
@@ -272,7 +272,7 @@ pub extern "C" fn init() -> i32 {
     0
 }
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn shutdown() -> i32 {
     log_info("{{plugin_name}} shutting down");
     0
@@ -282,7 +282,7 @@ pub extern "C" fn shutdown() -> i32 {
 // Command handlers
 // ============================================================================
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn cmd_{{command_name_snake}}() -> i32 {
     log_info("{{command_name}} command executed");
     show_notification(ToastLevel::Info, "Command executed!", 2000);
@@ -294,27 +294,27 @@ pub extern "C" fn cmd_{{command_name_snake}}() -> i32 {
 // ============================================================================
 
 /// UI render hook - customize component rendering
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn hook_ui_render() -> i32 {
     // Return 0 to continue with normal rendering
     0
 }
 
 /// Animation frame hook - called every frame for animations
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn hook_animation_frame(_frame: u64, _delta_us: u64) -> i32 {
     // Return 1 to request another frame, 0 to stop
     0
 }
 
 /// Focus change hook
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn hook_focus_change(_focused: i32) -> i32 {
     0
 }
 
 /// TUI event handler
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn hook_tui_event() -> i32 {
     0
 }
@@ -323,7 +323,7 @@ pub extern "C" fn hook_tui_event() -> i32 {
 // Custom action handlers
 // ============================================================================
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn action_{{plugin_id_snake}}_action() -> i32 {
     log_info("Custom action triggered via keybinding");
     show_notification(ToastLevel::Success, "Action executed!", 1500);