Skip to content

Commit 2cf951b

Browse files
committed
test(engine): assert /v1/me stays on the loopback port
Wiremock records localhost while CORTEX_API_URL uses 127.0.0.1; compare path and port instead of the host string. Co-authored-by: Mathis <echobt@users.noreply.github.com>
1 parent b4c5d44 commit 2cf951b

3 files changed

Lines changed: 18 additions & 13 deletions

File tree

Cargo.lock

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/cortex-cli/tests/whoami_me.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,15 @@ async fn whoami_hits_v1_me_on_configured_origin_never_production() {
7777
let requests = server.received_requests().await.expect("recorded requests");
7878
assert_eq!(requests.len(), 1);
7979
assert_eq!(requests[0].url.path(), "/v1/me");
80-
let host = requests[0].url.host_str().expect("loopback host");
81-
assert_ne!(host, "api.cortex.foundation");
80+
let request_url = requests[0].url.to_string();
8281
assert!(
83-
server.uri().contains(host),
84-
"request host {host} was not CORTEX_API_URL {}",
85-
server.uri()
82+
!request_url.contains("api.cortex.foundation"),
83+
"production host must not be contacted: {request_url}"
84+
);
85+
assert_eq!(
86+
requests[0].url.port(),
87+
url::Url::parse(&server.uri()).unwrap().port(),
88+
"request must stay on the loopback fixture port"
8689
);
8790
}
8891

src/cortex-engine/src/client/code_agent.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1268,15 +1268,15 @@ mod tests {
12681268
let requests = server.received_requests().await.expect("recorded requests");
12691269
assert_eq!(requests.len(), 1, "only /v1/me should be contacted");
12701270
assert_eq!(requests[0].url.path(), "/v1/me");
1271-
let host = requests[0]
1272-
.url
1273-
.host_str()
1274-
.expect("loopback request has a host");
1275-
assert_ne!(host, "api.cortex.foundation");
1271+
let request_url = requests[0].url.to_string();
12761272
assert!(
1277-
server.uri().contains(host),
1278-
"request host {host} was not the configured origin {}",
1279-
server.uri()
1273+
!request_url.contains("api.cortex.foundation"),
1274+
"production host must not be contacted: {request_url}"
1275+
);
1276+
assert_eq!(
1277+
requests[0].url.port(),
1278+
url::Url::parse(&server.uri()).unwrap().port(),
1279+
"request must stay on the loopback fixture port"
12801280
);
12811281
let auth = requests[0]
12821282
.headers

0 commit comments

Comments
 (0)