Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only export restbed symbols when building as a shared library + fix MinGW build #532

Closed
wants to merge 3 commits into from
Closed

Only export restbed symbols when building as a shared library + fix MinGW build #532

wants to merge 3 commits into from

Conversation

madebr
Copy link

@madebr madebr commented Oct 22, 2022 •
edited
Loading

Fixes #531 by:

  • only exporting the restbed symbols when building restbed as a shared library.
    On Windows, when linking to a static restbed, you now need to add -DRESTBED_STATIC to the compiler.
  • When installing, also install the binary component of a shared library. This is the .dll on Windows.
  • Fix issues when building restbed using MinGW@Linux. In addition to gcc@Linux, I used this toolchain to verify the correct symbol visibility of restbed's users.

Fixes #496 too

@madebr madebr force-pushed the export-is-optional branch from 2c484fb to b6a77ab Compare October 22, 2022 12:51
@madebr madebr mentioned this pull request Oct 22, 2022
Merged
4 tasks
@madebr madebr closed this Nov 25, 2023
@madebr madebr deleted the export-is-optional branch October 23, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot buid a static Windows restbed library without export any symbol build error on mingw
1 participant
@madebr