Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmwasm-std dev-dependency in cosmwasm-derive causes cargo release to fail #2186

Closed
chipshort opened this issue Jul 11, 2024 · 3 comments · Fixed by #2245
Closed

cosmwasm-std dev-dependency in cosmwasm-derive causes cargo release to fail #2186

chipshort opened this issue Jul 11, 2024 · 3 comments · Fixed by #2245

Comments

@chipshort
Copy link
Collaborator

The problem is:

  1. cargo release bumps the version to the not yet released one.
  2. cargo publish now seems to require the dev-dependencies to be present:
error: failed to verify package tarball

Caused by:
  failed to select a version for the requirement `cosmwasm-std = "^2.1.0"`
  candidate versions found which didn't match: 2.1.0-rc.1, 2.0.4, 2.0.3, ...
  location searched: crates.io index
  required by package `cosmwasm-derive v2.1.0 (/Users/christoph/Projects/cosmwasm/target/package/cosmwasm-derive-2.1.0)`
  if you are looking for the prerelease package it needs to be specified explicitly
      cosmwasm-std = { version = "2.1.0-rc.1" }
  perhaps a crate was updated and forgotten to be re-vendored?

I see two ways of avoiding this:

  1. depend on an older version for the dev-dependency and make sure cargo-release doesn't bump it.
  2. get rid of it completely
@chipshort chipshort changed the title cosmwasm-std dev-dependency in cosmwasm-derive causes cargo publish to fail cosmwasm-std dev-dependency in cosmwasm-derive causes cargo release to fail Jul 11, 2024
@webmaster128
Copy link
Member

Would this cargo publish option be helpful for the cosmwasm-derive step?

      --no-verify            Don't verify the contents by building them

@chipshort
Copy link
Collaborator Author

Yes, I guess --no-verify will work too, but I don't know if we can apply that on a per-crate basis when using cargo release, so we might have to do it on the full workspace.

@chipshort
Copy link
Collaborator Author

Another option: just mark the examples to not run.

mergify bot pushed a commit that referenced this issue Sep 24, 2024
Closes #2186

(cherry picked from commit e230048)

# Conflicts:
#	Cargo.lock
#	packages/derive/Cargo.toml
#	packages/derive/src/lib.rs
#	packages/std/src/lib.rs
mergify bot pushed a commit that referenced this issue Sep 24, 2024
Closes #2186

(cherry picked from commit e230048)

# Conflicts:
#	Cargo.lock
#	packages/derive/Cargo.toml
#	packages/derive/src/lib.rs
#	packages/std/src/lib.rs
mergify bot pushed a commit that referenced this issue Sep 24, 2024
Closes #2186

(cherry picked from commit e230048)

# Conflicts:
#	packages/derive/Cargo.toml
#	packages/derive/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants