Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark integer Key performance #7

Open
maurolacy opened this issue Mar 30, 2022 · 1 comment
Open

Benchmark integer Key performance #7

maurolacy opened this issue Mar 30, 2022 · 1 comment

Comments

@maurolacy
Copy link
Contributor

In CosmWasm/cw-plus#694 support for 128 bits integer keys was added.

There are some concerns with maximum integer key length, as it impacts all the int types.

Confirm this doesn't impact performance of reading / writing int keys to storage. It may be tricky to test / benchmark this, as code changes will be needed, to have a Key implementation with and without u128 support. This can be a one time benchmark, in a branch that we end up not merging to main, by example.

@maurolacy maurolacy changed the title Benchmark Key performance Benchmark integer Key performance Mar 30, 2022
@uint uint transferred this issue from CosmWasm/cw-plus Oct 17, 2022
@uint
Copy link
Contributor

uint commented Sep 27, 2024

We now know longer keys impact performance significantly - I doubt benchmarking this is worth the effort. The effect has been documented in the Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants