Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove InterfaceApi in favor of InterfaceMessagesApi #413

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird linked an issue Aug 7, 2024 that may be closed by this pull request
@kulikthebird kulikthebird force-pushed the tkulik/chore/interface_messages_api_cleanup branch from 3f97ef7 to 1e6b6c0 Compare August 7, 2024 20:50
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (0fa70ee) to head (e74f9ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   82.24%   82.11%   -0.14%     
==========================================
  Files          53       53              
  Lines        3098     3075      -23     
==========================================
- Hits         2548     2525      -23     
  Misses        550      550              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulikthebird kulikthebird force-pushed the tkulik/chore/interface_messages_api_cleanup branch from abfcdeb to ce8050c Compare August 8, 2024 07:56
@kulikthebird kulikthebird marked this pull request as ready for review August 8, 2024 07:56
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but please mark this change as breaking in commit message

@kulikthebird kulikthebird force-pushed the tkulik/chore/interface_messages_api_cleanup branch from ce8050c to ff3a585 Compare August 9, 2024 10:14
@kulikthebird kulikthebird changed the title chore: Remove InterfaceApi in favor of InterfaceMessagesApi chore!: Remove InterfaceApi in favor of InterfaceMessagesApi Aug 9, 2024
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Otherwise LGTM

sylvia-derive/src/interface/communication/api.rs Outdated Show resolved Hide resolved
@kulikthebird kulikthebird force-pushed the tkulik/chore/interface_messages_api_cleanup branch from ff3a585 to bb1fd5b Compare August 12, 2024 08:42
BREAKING CHANGE: Use InterfaceMessagesApi from generated `sv` module
instead
@kulikthebird kulikthebird force-pushed the tkulik/chore/interface_messages_api_cleanup branch from bb1fd5b to e74f9ef Compare August 12, 2024 08:44
@kulikthebird kulikthebird merged commit abfa2a5 into main Aug 12, 2024
8 of 9 checks passed
@kulikthebird kulikthebird deleted the tkulik/chore/interface_messages_api_cleanup branch August 12, 2024 09:15
@github-actions github-actions bot mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove InterfaceApi in favor of InterfaceMessagesApi
2 participants