Skip to content

Show panic information in handle_vm_panic #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
webmaster128 opened this issue Nov 6, 2024 · 0 comments · Fixed by #640
Closed

Show panic information in handle_vm_panic #570

webmaster128 opened this issue Nov 6, 2024 · 0 comments · Fixed by #640

Comments

@webmaster128
Copy link
Member

webmaster128 commented Nov 6, 2024

Right now, if there is a panic in cosmwasm-vm or libwasmvm, the output looks like this:

Panic in nice_try:
Any { .. }
This indicates a panic in during the operations of libwasmvm/cosmwasm-vm.
Such panics must not happen and are considered bugs. If you see this in any real-world or
close-to-real-world usage of wasmvm, please consider filing a security report,
no matter if it can be abused or not:
(https://github.com/CosmWasm/advisories/blob/main/SECURITY.md#reporting-a-vulnerability).
Thank you for your help keeping CosmWasm safe and secure 💚

where Any { .. } is all we get as the panic information. Not very helpful if things go wrong on a user's machine.

According to the discussion here, there is ways to get the panic string by downcasting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant