Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need memo field in ibc/applications/transfer/v1/MsgTransfer #11

Open
duguorong009 opened this issue May 18, 2023 · 2 comments
Open

Need memo field in ibc/applications/transfer/v1/MsgTransfer #11

duguorong009 opened this issue May 18, 2023 · 2 comments

Comments

@duguorong009
Copy link

Problem

Here, the MsgTransfer type does not have the memo field.
According the ICS spec, I think it should include the memo field, which is used for ibc-hook module of Cosmos-SDK.
This memo field is needed for advanced functionality, like cross-chain-swap.

Suggestion

I think the maintainers should include the latest proto files, and rebuild the TS types for juno network.
Then, it can include the new field - memo into the TS MsgTransfer type.

@Reecepbcups
Copy link
Contributor

Reecepbcups commented May 18, 2023

Agree - I made an issue on CosmJS main repo, but forgot about just doing it here. Will look into and take this on thanks!

Also helps with packet forward middleware

@Reecepbcups
Copy link
Contributor

Update you can use the following snippet to use the transfer value and sign + broadcast if you still need it

https://github.com/Reecepbcups/ibc-anywhere-webapp/blob/main/src/routes/%2Bpage.svelte#L437-L469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants