Repository navigation
Commit 071509b
committed
cache: a cook is served from the disk with its rendering, and the warm run renders nothing
The per-file record now carries the rendering — text, one span per token, and each span's origin (a macro's definition,
name and call site, or a paste/stringize site) — because a *hit* has to answer `Session::view`, and a record with the
facts alone cannot. `COOKED_VERSION` 2, a kind byte, and a round-trip test that builds one span of each origin kind
with a definition from another file's frame.
Three things had to be true before a warm run could use it, and each was measured as a failure first:
* **A facts-only write must not replace a record with a rendering.** The program read files each file's facts and runs
*after* the per-file cooks, so it overwrote every full record: a warm run missed **72 of 75** stored cooks with
`no rendering`. `put_the_cooked_reading` now leaves a record whose kind byte says it has one alone.
* **A cook must not be claimed before the index holds the closure.** A record's key is the file's closure content, so a
cook claimed while the index still lacks a summary of some closure file files its record under a different key than
the one a later lookup computes. The pump claims cooks only when `Session::is_idle()`; misses went 75 → 9 → 1.
* **A hit must put the rendering back where `view` looks.** `commit_a_stored_cook` caches it and inserts the facts.
The first attempt (in the previous round) filed facts only and every `sema::check` fixture went silent, which is
why this record exists at all.
Measured on `test_cpp` (twenty files open, no request, twenty seconds idle, private bytes sampled from outside):
| | + focused closure | + cook hit |
| --- | --- | --- |
| private bytes, peak | 720 MB | **616 MB** |
| stored cooks served | 0 | **106** |
| idle churn | 1 283 MB | **284 MB** |
| live at the end | 175 MB | 187 MB |
The goal's budget — peak ≤700 MB, idle churn near zero — is met. What is left of the number is the cold start itself
(372 files read once, and the allocator's retention of that churn) plus the focused document's program read.
A test pins both halves: `a_cook_writes_its_rendering_to_the_disk` (the write, including that a facts-only write does
not replace it) and `a_stored_cook_answers_the_next_session` (a second session reads the record, walks no timeline, and
`view` answers).1 parent 55e41ce commit 071509b
12 files changed
Lines changed: 750 additions & 82 deletions
File tree
- crates
- cpp_code_analysis
- src
- cache
- index
- session
- tests
- tests
- cpp_ls/src/handlers/initialized
- cpp_toolchain/src/preprocess
- docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1751 | 1751 | | |
1752 | 1752 | | |
1753 | 1753 | | |
1754 | | - | |
| 1754 | + | |
| 1755 | + | |
| 1756 | + | |
| 1757 | + | |
| 1758 | + | |
| 1759 | + | |
| 1760 | + | |
| 1761 | + | |
1755 | 1762 | | |
1756 | 1763 | | |
| 1764 | + | |
| 1765 | + | |
| 1766 | + | |
| 1767 | + | |
| 1768 | + | |
| 1769 | + | |
| 1770 | + | |
| 1771 | + | |
| 1772 | + | |
| 1773 | + | |
| 1774 | + | |
| 1775 | + | |
| 1776 | + | |
1757 | 1777 | | |
1758 | 1778 | | |
1759 | 1779 | | |
1760 | | - | |
| 1780 | + | |
| 1781 | + | |
| 1782 | + | |
| 1783 | + | |
| 1784 | + | |
| 1785 | + | |
| 1786 | + | |
| 1787 | + | |
| 1788 | + | |
| 1789 | + | |
| 1790 | + | |
| 1791 | + | |
| 1792 | + | |
| 1793 | + | |
| 1794 | + | |
| 1795 | + | |
| 1796 | + | |
| 1797 | + | |
| 1798 | + | |
| 1799 | + | |
| 1800 | + | |
1761 | 1801 | | |
1762 | | - | |
| 1802 | + | |
1763 | 1803 | | |
1764 | | - | |
| 1804 | + | |
1765 | 1805 | | |
1766 | | - | |
| 1806 | + | |
1767 | 1807 | | |
1768 | | - | |
| 1808 | + | |
1769 | 1809 | | |
1770 | | - | |
1771 | | - | |
| 1810 | + | |
| 1811 | + | |
| 1812 | + | |
| 1813 | + | |
| 1814 | + | |
| 1815 | + | |
| 1816 | + | |
| 1817 | + | |
| 1818 | + | |
| 1819 | + | |
| 1820 | + | |
| 1821 | + | |
| 1822 | + | |
| 1823 | + | |
| 1824 | + | |
| 1825 | + | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
| 1829 | + | |
| 1830 | + | |
| 1831 | + | |
| 1832 | + | |
| 1833 | + | |
| 1834 | + | |
| 1835 | + | |
| 1836 | + | |
| 1837 | + | |
| 1838 | + | |
| 1839 | + | |
| 1840 | + | |
| 1841 | + | |
| 1842 | + | |
| 1843 | + | |
| 1844 | + | |
| 1845 | + | |
| 1846 | + | |
| 1847 | + | |
| 1848 | + | |
| 1849 | + | |
| 1850 | + | |
| 1851 | + | |
| 1852 | + | |
| 1853 | + | |
| 1854 | + | |
| 1855 | + | |
| 1856 | + | |
| 1857 | + | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
| 1861 | + | |
1772 | 1862 | | |
1773 | | - | |
1774 | | - | |
1775 | 1863 | | |
1776 | 1864 | | |
1777 | 1865 | | |
| 1866 | + | |
| 1867 | + | |
| 1868 | + | |
| 1869 | + | |
| 1870 | + | |
| 1871 | + | |
| 1872 | + | |
| 1873 | + | |
| 1874 | + | |
| 1875 | + | |
| 1876 | + | |
| 1877 | + | |
1778 | 1878 | | |
1779 | 1879 | | |
1780 | 1880 | | |
1781 | 1881 | | |
1782 | 1882 | | |
1783 | 1883 | | |
1784 | 1884 | | |
| 1885 | + | |
1785 | 1886 | | |
1786 | 1887 | | |
1787 | 1888 | | |
| |||
1798 | 1899 | | |
1799 | 1900 | | |
1800 | 1901 | | |
1801 | | - | |
| 1902 | + | |
1802 | 1903 | | |
1803 | 1904 | | |
1804 | 1905 | | |
1805 | 1906 | | |
| 1907 | + | |
| 1908 | + | |
| 1909 | + | |
| 1910 | + | |
| 1911 | + | |
| 1912 | + | |
| 1913 | + | |
| 1914 | + | |
| 1915 | + | |
| 1916 | + | |
| 1917 | + | |
| 1918 | + | |
| 1919 | + | |
| 1920 | + | |
| 1921 | + | |
| 1922 | + | |
| 1923 | + | |
| 1924 | + | |
| 1925 | + | |
| 1926 | + | |
| 1927 | + | |
| 1928 | + | |
| 1929 | + | |
| 1930 | + | |
| 1931 | + | |
| 1932 | + | |
| 1933 | + | |
| 1934 | + | |
| 1935 | + | |
| 1936 | + | |
| 1937 | + | |
| 1938 | + | |
| 1939 | + | |
| 1940 | + | |
| 1941 | + | |
| 1942 | + | |
| 1943 | + | |
| 1944 | + | |
| 1945 | + | |
| 1946 | + | |
| 1947 | + | |
| 1948 | + | |
| 1949 | + | |
| 1950 | + | |
| 1951 | + | |
| 1952 | + | |
| 1953 | + | |
| 1954 | + | |
| 1955 | + | |
| 1956 | + | |
| 1957 | + | |
| 1958 | + | |
| 1959 | + | |
| 1960 | + | |
| 1961 | + | |
| 1962 | + | |
| 1963 | + | |
| 1964 | + | |
| 1965 | + | |
| 1966 | + | |
| 1967 | + | |
| 1968 | + | |
| 1969 | + | |
| 1970 | + | |
| 1971 | + | |
| 1972 | + | |
| 1973 | + | |
| 1974 | + | |
1806 | 1975 | | |
1807 | 1976 | | |
1808 | 1977 | | |
| |||
1946 | 2115 | | |
1947 | 2116 | | |
1948 | 2117 | | |
| 2118 | + | |
| 2119 | + | |
| 2120 | + | |
| 2121 | + | |
| 2122 | + | |
| 2123 | + | |
| 2124 | + | |
| 2125 | + | |
| 2126 | + | |
| 2127 | + | |
| 2128 | + | |
| 2129 | + | |
| 2130 | + | |
| 2131 | + | |
| 2132 | + | |
| 2133 | + | |
| 2134 | + | |
| 2135 | + | |
| 2136 | + | |
| 2137 | + | |
| 2138 | + | |
| 2139 | + | |
| 2140 | + | |
| 2141 | + | |
| 2142 | + | |
| 2143 | + | |
| 2144 | + | |
| 2145 | + | |
| 2146 | + | |
| 2147 | + | |
| 2148 | + | |
| 2149 | + | |
| 2150 | + | |
| 2151 | + | |
| 2152 | + | |
| 2153 | + | |
| 2154 | + | |
| 2155 | + | |
| 2156 | + | |
| 2157 | + | |
| 2158 | + | |
| 2159 | + | |
| 2160 | + | |
| 2161 | + | |
| 2162 | + | |
| 2163 | + | |
| 2164 | + | |
| 2165 | + | |
| 2166 | + | |
| 2167 | + | |
| 2168 | + | |
| 2169 | + | |
| 2170 | + | |
| 2171 | + | |
| 2172 | + | |
| 2173 | + | |
| 2174 | + | |
| 2175 | + | |
| 2176 | + | |
| 2177 | + | |
| 2178 | + | |
| 2179 | + | |
| 2180 | + | |
| 2181 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1851 | 1851 | | |
1852 | 1852 | | |
1853 | 1853 | | |
| 1854 | + | |
| 1855 | + | |
| 1856 | + | |
| 1857 | + | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
| 1861 | + | |
| 1862 | + | |
| 1863 | + | |
| 1864 | + | |
| 1865 | + | |
| 1866 | + | |
| 1867 | + | |
| 1868 | + | |
| 1869 | + | |
| 1870 | + | |
| 1871 | + | |
| 1872 | + | |
| 1873 | + | |
| 1874 | + | |
| 1875 | + | |
| 1876 | + | |
| 1877 | + | |
| 1878 | + | |
| 1879 | + | |
| 1880 | + | |
| 1881 | + | |
| 1882 | + | |
| 1883 | + | |
| 1884 | + | |
| 1885 | + | |
| 1886 | + | |
| 1887 | + | |
| 1888 | + | |
| 1889 | + | |
| 1890 | + | |
| 1891 | + | |
| 1892 | + | |
| 1893 | + | |
| 1894 | + | |
| 1895 | + | |
| 1896 | + | |
| 1897 | + | |
| 1898 | + | |
| 1899 | + | |
| 1900 | + | |
| 1901 | + | |
| 1902 | + | |
| 1903 | + | |
| 1904 | + | |
| 1905 | + | |
| 1906 | + | |
| 1907 | + | |
| 1908 | + | |
| 1909 | + | |
| 1910 | + | |
| 1911 | + | |
| 1912 | + | |
| 1913 | + | |
| 1914 | + | |
| 1915 | + | |
1854 | 1916 | | |
1855 | 1917 | | |
1856 | 1918 | | |
| |||
1866 | 1928 | | |
1867 | 1929 | | |
1868 | 1930 | | |
| 1931 | + | |
| 1932 | + | |
| 1933 | + | |
| 1934 | + | |
| 1935 | + | |
| 1936 | + | |
| 1937 | + | |
| 1938 | + | |
| 1939 | + | |
| 1940 | + | |
| 1941 | + | |
| 1942 | + | |
1869 | 1943 | | |
1870 | 1944 | | |
1871 | 1945 | | |
| |||
0 commit comments