Repository navigation
Commit 751d664
committed
session: a fixture directory is unique to its run, and the note that said "ignored" is gone
`a_class_scoped_by_another_files_macro_body_is_scoped_through_the_session` was reported failing on every rerun with
`Unknown(NotDeclaredHere("studio::Widget"))`. It passes here — alone, in the whole `session::` group, in the full lib
suite, cold and warm, release and debug — so the *first* failing run was not reproduced; what was found is the
mechanism by which its result survives every rerun.
The fixtures shared one tree per name (`%TEMP%\cppls-session-disk\body-pass`) and the cleanup was
`let _ = std::fs::remove_dir_all(&root);`. The sessions write their summaries under `<fixture>/.cppls`, so a directory
that could not be removed — a file held open by another process on Windows, a run that aborted before its `Drop` — was
read as the *next* run's state: a summary of `widget.h` keyed by its own (unchanged) bytes, answering the old
namespace, for every rerun. `a_fresh_fixture_directory` gives each fixture the name, the process id and a serial, so a
stale directory is unreachable rather than merely unlikely, and two concurrent runs cannot delete each other's files.
`a_fixture_directory_is_unique_to_its_run` pins both properties.
The test's comment said "ignored while the refined reading is being fixed" and there was no `#[ignore]` — the note was
written for a behaviour that later landed, so it is replaced with what the test now pins.
Also recorded: the obvious fix — draining `refinements_wanted()` at the end of `index_everything` so `pending_work()` is
zero on return — was written, measured and reverted. It makes this test pass and breaks
`a_body_edit_does_not_cost_the_program_again` and `a_program_is_read_when_the_reader_stops_editing`: the unit read is
deferred to the pump's idle step on purpose. `docs/buglist.md` section 33 and `docs/next.md` section 8 carry the
measurement so the next attempt starts from it.1 parent 592f86c commit 751d664
3 files changed
Lines changed: 145 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
11 | 31 | | |
12 | 32 | | |
13 | 33 | | |
| |||
22 | 42 | | |
23 | 43 | | |
24 | 44 | | |
25 | | - | |
26 | | - | |
| 45 | + | |
27 | 46 | | |
28 | 47 | | |
29 | 48 | | |
| |||
3596 | 3615 | | |
3597 | 3616 | | |
3598 | 3617 | | |
3599 | | - | |
3600 | | - | |
| 3618 | + | |
3601 | 3619 | | |
3602 | 3620 | | |
3603 | 3621 | | |
| |||
3662 | 3680 | | |
3663 | 3681 | | |
3664 | 3682 | | |
| 3683 | + | |
| 3684 | + | |
| 3685 | + | |
| 3686 | + | |
| 3687 | + | |
| 3688 | + | |
| 3689 | + | |
| 3690 | + | |
| 3691 | + | |
| 3692 | + | |
| 3693 | + | |
| 3694 | + | |
| 3695 | + | |
| 3696 | + | |
| 3697 | + | |
| 3698 | + | |
| 3699 | + | |
| 3700 | + | |
| 3701 | + | |
| 3702 | + | |
| 3703 | + | |
| 3704 | + | |
| 3705 | + | |
| 3706 | + | |
| 3707 | + | |
| 3708 | + | |
| 3709 | + | |
| 3710 | + | |
| 3711 | + | |
| 3712 | + | |
| 3713 | + | |
| 3714 | + | |
| 3715 | + | |
3665 | 3716 | | |
3666 | | - | |
3667 | | - | |
3668 | | - | |
3669 | 3717 | | |
3670 | 3718 | | |
3671 | 3719 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1074 | 1074 | | |
1075 | 1075 | | |
1076 | 1076 | | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
182 | 206 | | |
183 | 207 | | |
184 | 208 | | |
| |||
0 commit comments