-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adjusting the key bind for Place/Remove Knots #368
Comments
So it seems to industry trends toward SHIFT for adding whereas CTRL is used for mutating existing elements. |
We should avoid the use of CTRL entirely, specifically because CTRL+LMB allows for multi-node selection. We should retain this behavior to allow users to multi-select reroute/knot nodes. |
I have a good practical reason for this change: This key bind (Control + LMB) is straight up impossible on MacOS because the OS is hard coded to produce a secondary mouse click event (right click) whenever Control + LMB is pressed. You cannot change this in the OS anywhere, it's just how it works. I currently cannot add knots to my node graphs. |
I was looking here if an issue exists for "implementing reroute nodes" and found out that it's already implemented. So why I thought it's not build in? The method is not very intuitive. I'm usually working with Unreal Engine and there you have 2 methods that do not exist here, but are very straight forward: double click on LMB on graph to create a knot or drag and drop a line and write "knot" - it pops up as node inside the list (if I remember correctly, it's also pinned in that box). I think both methods could be implemented in additional here, too. Ctrl+LMB can stay as it is in my opinion. Nothing wrong in giving multiple ways for such an important feature. The way with drag and drop (or right click to search for) is something playing together with #758 very well and is very beginner friendly. Double click on LMB reduces the hurdle a lot for people coming from Unreal to Godot. |
Description
Placing and removing many knots on the graph using the same key binding is likely not ideal. We should consider using SHIFT+LMB and CTRL+LMB and decide which of the two bindings refers to placement versus removal.
This could go in parallel with #367 so that users have full control over such bindings in the end.
Implementation ideas
No response
The text was updated successfully, but these errors were encountered: