Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using highlight connections, wire highlighting does not seem to reset. #369

Open
Naros opened this issue May 19, 2024 · 2 comments · May be fixed by #377
Open

When using highlight connections, wire highlighting does not seem to reset. #369

Naros opened this issue May 19, 2024 · 2 comments · May be fixed by #377
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.

Comments

@Naros
Copy link
Member

Naros commented May 19, 2024

Describe the bug

When using the highlight connections option, the highlight resets for the nodes, but the connection wires do not seem to reset under certain conditions and use cases:

image

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

No response

Additional information

No response
@Naros Naros added the kind/bug A bug or regression in expected behavior. label May 19, 2024
@Naros
Copy link
Member Author

Naros commented May 27, 2024

So this seems to happen when adding knots to the connection wires.

@Naros Naros added bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels May 27, 2024
@Naros
Copy link
Member Author

Naros commented May 27, 2024

@eobet, this is in part to a Godot 4.3 bug with the new GraphEdit changes that break compatibility with Godot 4.2:
godotengine/godot#92443

Naros added a commit to Naros/godot-orchestrator that referenced this issue May 27, 2024
@Naros
CraterCrashGH-369 Fix highlight selected nodes feature
b8b090e
@Naros Naros linked a pull request May 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-369 Fix highlight selected nodes feature Naros/godot-orchestrator
1 participant
@Naros