Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MovieClip advance not changing frames due to fps being undefined #925

Open
hiperbou opened this issue Nov 20, 2017 · 0 comments
Open

MovieClip advance not changing frames due to fps being undefined #925

hiperbou opened this issue Nov 20, 2017 · 0 comments
Assignees

Comments

@hiperbou
Copy link

Hello,
I'm using Ticker, to manually tick to my MovieClips. It happens that when a movieclip is a child of another that is not ticked, the timeline never updates. The function advance, searches for ancestor's framerate, but it the stage is never reached, so it ends with the fps variable being undefined and failing the test on the following line:

var t = (fps !== null && fps !== -1 && time !== null) ? time/(1000/fps) + this._t : 1;

It could be fixed, using a non-strict null comparision to handle the undefined value also.
var t = (fps != null && fps !== -1 && time !== null) ? time/(1000/fps) + this._t : 1;

I could do a pull request if required, but I rather know that this will not break something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants