Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpriteSheetLoader bug? #179

Open
gregmax17 opened this issue Jan 6, 2016 · 2 comments
Open

SpriteSheetLoader bug? #179

gregmax17 opened this issue Jan 6, 2016 · 2 comments

Comments

@gregmax17
Copy link

I "think" this might be a bug when using the LoadQueue to a manifest of files, one being a sprite sheet type.

In the SpirteSheetLoader the method "_handleManifestFileLoad", it checks and updates the json object with the image loaded with the images array at the appropriate index by the item's src value. However, when I use the LoadQueue I'm setting the second parameter for my base path, so when my image's load its src value is incorrect and the json's object images array is never set properly. Does this make sense? The item's src value contains the base path, but images values in my json object doesn't.

I'm able to get around this for now by having it check by the item id value instead of the src.

Any help would be great, thanks!

@sergebat
Copy link

I second this issue!

Given that basePath is being deprecated, I worked it around by doing the following in _loadManifest:

queue.loadManifest({path: this._item.path, manifest: json.images});

And then looking up image

var pos = images.indexOf(event.item.src.substring(event.item.path.length));

One way, or the other I hope this will get fixed. 👍

@fabian
Copy link

fabian commented May 3, 2016

See #169.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants