Skip to content

Strict borrower authentication on draw_credit #152

@greatest0fallt1me

Description

@greatest0fallt1me

Description

Ensure the borrower address must authorize draw_credit and document any delegate or contract-account caveats.

Requirements and context

  • Negative tests with third-party signers.
  • Security notes in PR.

Suggested execution

Fork and branch

Fork the repo and create a branch:

git checkout -b test/borrower-auth-draw

Implement changes

  • Audit draw_credit auth in lib.rs.
  • Add mock_auths negative cases.

Test and commit

Run the full test suite, cover edge cases, and include test output plus security notes (assumptions, trust boundaries, failure modes) in the PR description.

Run tests

cargo test -p creditra-credit

Example commit message

test(credit): borrower auth requirements for draw_credit

Guidelines

  • Minimum 95% line coverage (cargo llvm-cov as documented in the contracts README).

  • Clear documentation (Rust /// doc comments on public items; update docs/credit.md when behavior changes).

  • Timeframe: 96 hours.

  • Optionally run: cargo llvm-cov --workspace --all-targets --fail-under-lines 95 before merge.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions