Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry suggestions / user-guided duplicate detection #220

Closed
aarontitus opened this issue May 1, 2013 · 9 comments
Closed

Entry suggestions / user-guided duplicate detection #220

aarontitus opened this issue May 1, 2013 · 9 comments

Comments

@aarontitus
Copy link
Member

Original author: [email protected] (March 19, 2013 17:53:38)

Aaron wrote, in #83:

For ENTRY duplicate detection, I think there may be a lightweight pre-duplicate detection validation we could implement by applying the same AJAX we use in the map search feature ( #63 ). For example, if I type, "Scot" in the name, address, city or phone number, then the following results may automatically appear under the entry. By selecting one of them, I would be taken directly to the "Edit" page:
<Scott Smith, 123 Main Street, Union City NJ 01234>
<Jim Jones, 476 Scotch Plains Ave, Rockaway, NY 12345>
<Fria Lima, 9377 Home St, Scottsdale, CT 23905>

This would require that the map AJAX be loaded each time someone enters an assessment form. We may want to find a way to cache that once per session for the assessment form. But it seems like a quick way to minimize entry duplicates.

NOTE: This is NOT system-driven duplicate detection, and this process will not detect duplicates imported (see #83)

Original issue: http://code.google.com/p/sandy-disaster-recovery/issues/detail?id=220

@aarontitus
Copy link
Member Author

From [email protected] on March 19, 2013 17:56:38
An Autocompleter can be toggled in form.js.

Need to stop it from overwriting/filling/updating input elements when tabbing away/past. Could replace with a custom implementation using ArrayMatcher.

@aarontitus
Copy link
Member Author

From [email protected] on March 19, 2013 19:50:59
inputHandler.setPreventDefaultOnTab(true) doesn't seem to work.

@aarontitus
Copy link
Member Author

From [email protected] on March 20, 2013 10:18:05
A possible solution: have a partly-hidden text input with autocompleter somewhere else on the form (at the top?) and copy characters from the other target inputs as they are typed.

@aarontitus
Copy link
Member Author

From [email protected] on March 20, 2013 16:01:01
I like this idea- it seems far less invasive.
Or perhaps a separate field that lists all possible duplicates; and the list shortens as you continue to type additional characters.

@aarontitus
Copy link
Member Author

From [email protected] on March 25, 2013 19:10:31
New UI for this is now live on the testbed (version 161).

Note: it only works as fast as the sites/work orders are loaded! (#219)

@aarontitus
Copy link
Member Author

From [email protected] on March 25, 2013 19:31:43
Comment 6: LOVE IT! I understand that it only works as fast as the sites/work orders are loaded. Man, what an improvement.

And I really like the new warning. Is it possible to replace "To ignore this warning, select the checkbox at the bottom of this form." with a button that says "Ignore and Save," so that the person doesn't have to scroll all the way to the bottom?

@aarontitus
Copy link
Member Author

From [email protected] on March 25, 2013 20:02:02
Great. I've moved the second half of #7 back to #83.

@aarontitus
Copy link
Member Author

From [email protected] on March 26, 2013 12:49:31
This is now live on production.

Main defect: it does the same search regardless of which field is typed in - e.g. if you type "park" in address then " 1 Main Street" would match.

@aarontitus
Copy link
Member Author

From [email protected] on March 26, 2013 14:06:42
Agreed that this is a minor defect. But it's a massive improvement. I'm marking it done. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant