Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success banner shown after request failed #1164

Open
nilbus opened this issue Oct 2, 2024 · 0 comments
Open

Success banner shown after request failed #1164

nilbus opened this issue Oct 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@nilbus
Copy link

nilbus commented Oct 2, 2024

Description

During the performance issues, I happened to have Chrome Inspector's Network tab open and saw that the update_phone_number_completion request failed with a CORS error, probably just due to the site outage since it normally works fine. However, the UI lied and showed a green success banner.

Expected Behavior

Error message if any fetch/XHR request fails.

Current Behavior

  1. Access to XMLHttpRequest at 'https://api.crisiscleanup.org/phone_outbound/update_phone_number_completion' from origin 'https://crisiscleanup.org' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.
  2. A success message in a green banner is displayed with the text, "Phone number removed from queue."
@nilbus nilbus added the bug Something isn't working label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant