Repository navigation
Decode native Dolby Vision video-only screenshots before export - #246
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #243.
On RC1, a native video-only screenshot can read the RGB8 Dolby Vision HDMI carrier as though it were logical PQ video. In the verified P5 Master Reference example, the PNG had a purple tint while a composite capture of the same paused frame decoded correctly. This change uses the existing logical image readback, preserves the video crop and signed stride, and keeps the output's color metadata. If the prepared picture already contains a GUI or subtitle overlay, the video-only operation now reports the cause and emits no file. Composite captures remain available in that case.
Verified on N100 and Ryzen 7430U: 4K FEL video-only PNGs are 16-bit RGB tagged BT.2020/PQ before opening the OSD and after closing it; video-only emits no file with the OSD active; composite with the OSD, native SDR and native HDR10 still produce screenshots. This fixes the reproduced video-only path. The original report's untagged 8-bit PNG on the NUC plus LG G6 still needs a controlled retest with the original capture command.