support websocket compression #675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gittiver
requested review from
mrozigor,
dranikpg,
The-EDev and
luca-schlecker
mrozigor
reviewed
Mar 9, 2024
| @@ -555,7 +603,11 @@ namespace crow | |||
| if (is_FIN()) | |||
There was a problem hiding this comment.
Maybe move this if to separate method?
mrozigor
reviewed
Mar 9, 2024
| #ifdef CROW_ENABLE_COMPRESSION | ||
| if (compressor_) | ||
| { | ||
| opcode += 0x40; |
There was a problem hiding this comment.
Couldn't find where this comes from. May I ask you to send a link to spec? ;)
There was a problem hiding this comment.
Sure. I'll look for it. Might take some time. I'm currently very busy sadly.
|
May I ask you to provide unit tests? |
|
I'll try to add some unit-tests for this. Thanks for the review. |
gittiver
added
the
further information required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for websocket compression via permessage-deflate extension. It's based on ipkn/crow#329, with a few changes to better match current crow. It resolves #92
I was not able to use the current implementation of zlib. This needs state, which the current implementation does not support. It's enabled whenever CROW_ENABLE_COMPRESSION is defined.
I tested it with my very websocket heavy app on recent chrome and firefox and it works as expected. Please let me know, if there's anything I need to change.