Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove model service from local dev stack and override url in production #113

Conversation

chris-dickson
Copy link
Contributor

@chris-dickson chris-dickson commented Mar 6, 2023

This removes the model-service component from the local stack and defaults to the staging hosted version. In production we use the local version.

This PR must coincide with DARPA-ASKEM/terarium#799

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But why not add the URL for staging on the local? Why removing it on local?

@chris-dickson
Copy link
Contributor Author

The URL is specified within Terarium itself. This pr just removes the service from running locally

@chris-dickson chris-dickson merged commit 391da32 into main Mar 6, 2023
@chris-dickson chris-dickson deleted the 112-task-remove-model-service-from-local-stack-and-configure-it-for-running-in-aws branch March 6, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: remove model-service from local stack and configure it for running in aws
2 participants