Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Need to set Stratify's param_renaming_uses_strata_names to True #4304

Closed
liunelson opened this issue Jul 29, 2024 · 0 comments
Closed
Assignees
Labels
bug Something isn't working feature New feature or request

Comments

@liunelson
Copy link
Member

liunelson commented Jul 29, 2024

Currently, Stratify Model creates new parameters with name like <param_name>_0, <param_name>_1, ... instead of using the strata names that the user provides.

In the most recent version of MIRA, Ben added a new argument to mira.metamodel.ops.stratify called param_renaming_uses_strata_names to toggle whether the newly created parameters are named <param_name>_<strata_name_0>, <param_name>_<strata_name_1>, ...

TLDR: we should call mira.metamodel.ops.stratify(..., param_renaming_uses_strata_names = True)

This might impact the UI parameter matrix generation?

@github-actions github-actions bot added the bug Something isn't working label Jul 29, 2024
@liunelson liunelson added feature New feature or request and removed bug Something isn't working labels Jul 29, 2024
@github-actions github-actions bot added the bug Something isn't working label Jul 29, 2024
@mwdchang mwdchang assigned Tom-Szendrey and unassigned mwdchang Jul 29, 2024
@mwdchang mwdchang assigned mwdchang and unassigned Tom-Szendrey Aug 6, 2024
@mwdchang mwdchang closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants