Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Export Model Config and Model at once, zipped #4316

Closed
dvince2 opened this issue Jul 30, 2024 · 0 comments · Fixed by #4669
Closed

[FEAT]: Export Model Config and Model at once, zipped #4316

dvince2 opened this issue Jul 30, 2024 · 0 comments · Fixed by #4669
Assignees
Labels
feature New feature or request

Comments

@dvince2
Copy link
Collaborator

dvince2 commented Jul 30, 2024

Is your feature request related to a problem? Please describe.
Currently when a user exports a model config from the workflow node, what is exported is a configured AMR. If this is then imported back into terarium a default configuration is created for the mode with the correct values, however, its missing the "extra" information from that configuration like its name, description, sources etc

Describe the solution you'd like
Rather than exporting a configured AMR (or in addition to?), we want to export both the model's JSON and the configuration's JSON inside of a zip archive. This zip archive will then be able to be uploaded back into terarium to import both the model and the configuration with all of its information intact

Describe alternatives you've considered
Another option is using the AMR's metadata, but, this will result in a lot of edge cases to consider.

Additional context
Add any other context or screenshots about the feature request here.

@dvince2 dvince2 added the feature New feature or request label Jul 30, 2024
@dvince2 dvince2 self-assigned this Aug 26, 2024
dvince2 added a commit that referenced this issue Sep 4, 2024
When a user downloads a model configuration now they will receive a zipped archive that includes the original model and the configuration.  This will preserve all the metadata and information that was included in the configuration and not present it as a 'default configuration'.  I've opted to not use the extension `.zip` because it would be slightly harder to verify whats coming in to us.
@dvince2 dvince2 linked a pull request Sep 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant