Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation and Calibration should same output section as Optimize #4371

Closed
Tom-Szendrey opened this issue Aug 6, 2024 · 4 comments
Closed
Assignees
Labels
Enhancement Improvements to features already in the application

Comments

@Tom-Szendrey
Copy link
Contributor

Image

Image

@Tom-Szendrey Tom-Szendrey self-assigned this Aug 6, 2024
@Tom-Szendrey Tom-Szendrey added the Enhancement Improvements to features already in the application label Aug 7, 2024
@Tom-Szendrey
Copy link
Contributor Author

Tom-Szendrey commented Aug 7, 2024

Show mean for both simulation plot and interventions
On by default

@Tom-Szendrey Tom-Szendrey changed the title Simulation and Calibration should have an "interventions" section Simulation and Calibration should same output section as Optimize Aug 13, 2024
@Tom-Szendrey Tom-Szendrey linked a pull request Aug 14, 2024 that will close this issue
@Tom-Szendrey
Copy link
Contributor Author

#4457 (comment)

Some of the design elements are problematic, not really up-to-date with the latest thinking, or are some what contradictory. For example we'd need to think about how these settings are going to work with reporting features
Likewise, the "chartConfig" is getting rejigged to take into consideration annotations, this will impact how we would pass things back and forth between the operator drilldown and the settings panel as they wouldn't be just variable string arrays
It would still be good to assess the situation in a more systematic manner. It may be nice, if possible, for each operator to provide a generator function of its output-settings, and how the settings should be displayed.

@Tom-Szendrey
Copy link
Contributor Author

Tom-Szendrey commented Aug 15, 2024

Things to discuss:

  1. Problematic design elements such as some sections of the form being filled in prior to run and others being filled in after.
  • Do we want to generate summary (Before)
    This generate summary will be moved outside of this settings panel.
    This will be likely a workflow or project level setting

  • What variables and charts do we want to look at? (After)
    With new designs we will be moving everything to after.

  1. Each drilldown has different charts. Does this design allow for that flexibility?
  • Interventions (all 3)
  • Simulations allowing one selection (Optimize, Calibrate)
  • Simulations allowing multiple selections (Simulate)
  • Success Criteria (Optimize)
  • Calibrated Parameter charts. (Calibrate)
    Each output settings panel is completely customized per operator
  1. What designs for the reporting system and how will this impact our choices here?
    When a user hits add to report. This will create a copy of the current snapshot and send to the report.
    If the users reruns the operator, or changes the output settings this will not impact what
    has been added to the report.

  2. Optimize, calibrate, and simulate utilize different ways of getting and displaying chart data.
    Do we want to uniform this? Do we want to use the chartConfig method vs the preparedCharts method?
    No.
    We can factor into individual util.ts though

  3. Will all operators have this output settings?
    No. Some operators will not have this output settings section. Operators such as stratify will not.

  4. User is unhappy with what was added to the report. What is the workflow?

  5. Jaehwan to define chart config type

@dgauldie dgauldie assigned mwdchang and unassigned Tom-Szendrey Aug 23, 2024
@dgauldie
Copy link
Collaborator

dgauldie commented Sep 9, 2024

duplicate

@dgauldie dgauldie closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to features already in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants