Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable implicit grouping by slicing #70

Open
johentsch opened this issue Jan 16, 2024 · 0 comments
Open

Enable implicit grouping by slicing #70

johentsch opened this issue Jan 16, 2024 · 0 comments

Comments

@johentsch
Copy link
Member

Fitting a slicer to a grouped dataset, say grouped by mode, currently makes it fail on features that have not been grouped by mode.

In a typical case, SliceIntervals obtained from some grouped Feature to be used for slicing would have the levels corpus, piece, mode, intervals. In principle, it will be possible to use Feature.apply_slice_intervals() even when a feature does not have a mode level (i.e., it hasn't been grouped by mode, e.g. because it's Notes that don't come with keys by default).

Suggested solution

Dropping the mode level from the SliceIntervals, applying it to the feature, re-adding the mode level through a join operation.

johentsch pushed a commit to johentsch/dimcat that referenced this issue Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant