-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Calvo3 (or Paco's method) in local_fast_trainer #57
Comments
The thing is that I have to change code in training_engine_sae.py, which contains the generator function for extracting samples. However, that module is used by other two modules: So, I have to modify these 3 files to include this feature. I could test the local script, but the fast_calvo_trainer.py module uses the rodan library. For that, I mentioned about the rodan dependencies. |
If all the changes will be in Alternatively, you’re welcome to change all the current files in a branch other than I think both are fine, depends on which workflow you find more appropriate. |
I think that a new branch and modifying the code in the current files will be better than having duplicated files, because also I would need a new file for training_engine_sae.py since the current scripts use the old version of that module. |
Sure, makes sense. We’ll work on implementing the changes inside the Rodan job wrapper once the local version is working and pushed to develop. |
Hi!, in the branch "sample_generator" we have now a version of the Paco's method. I have prepared two manners of using the code. Also, I have included instructions in the README.md file (I did not delete the previous information just in case you need it). |
I'll test it locally today and try to get a CC setup going as well. If all this good, we can work on implementing it into a Rodan job and pushing it onto staging. |
This new method is an extension of the Calvo2 method (using random uniformly distributed samples from 5 images to generate training batches).
According to @fjcastellanos, this is what is needed for Calvo3 (Paco's method):
@fjcastellanos, based on my understanding of the code, the changes you propose should be implemented on
local_fast_trainer.py
file, in a new branch derived fromdevelop
.That script is independent of Rodan and can be trained locally, so it will allow you to iterate quickly over your changes.
@kemalkongar has volunteered to help you oversee those changes if you need it.
Preferably, push your changes to your branch frequently, and we (e.g., @kemalkongar or myself) can jump in to peer-review the code or help if needed.
The text was updated successfully, but these errors were encountered: