Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "siglum" on "Sequence" model? #1534

Open
ahankinson opened this issue Jun 16, 2024 · 1 comment
Open

Drop "siglum" on "Sequence" model? #1534

ahankinson opened this issue Jun 16, 2024 · 1 comment
Assignees

Comments

@ahankinson
Copy link
Member

The "siglum" text field seems like it's a leftover from the migration. Since the Sequence model is already connected to the source, and can get the source information there, it's likely this will gradually lead to divergences between what is in the text field, and what source the sequence is actually connected to.

Unless I'm missing something, the siglum field can probably be dropped?

Maybe this is one that @annamorphism can weigh in on?

@annamorphism
Copy link

I agree, in the long-term. Shorter term, there are some existing divergences in the Bower database that need to be cleaned up--cases where sequences were not correctly attached to a source in the first place when the data was put in. These are all attached to the "Unknown Source" right now (https://cantusdatabase.org/source/1000004) but many of the sequences do have siglum information that will help them get attached to an actual source at some point.

So: I say this could be made something that most people don't see, and nobody edits or add to, but that is still accessible somewhere for people who need it to clean up the Bower data.

ahankinson added a commit that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants