Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect usage of the <small> element #1550

Open
ahankinson opened this issue Jun 19, 2024 · 1 comment
Open

Incorrect usage of the <small> element #1550

ahankinson opened this issue Jun 19, 2024 · 1 comment
Assignees

Comments

@ahankinson
Copy link
Member

ahankinson commented Jun 19, 2024

In several templates the <small> element is used to make everything in that block smaller. However, this element is not a block-level element, and should not be used this way.

The Bootstrap Toolkit has the .small class that can be used to make things smaller.

For reference:

image

image

@dchiller dchiller self-assigned this Aug 1, 2024
@dchiller
Copy link
Contributor

dchiller commented Aug 1, 2024

I'm going to hold off on this until we upgrade to Django 5. In starting to correct this, I discovered that most places we use this element are in forms, and that we do form fields inconsistently. Django 5 looks like it contains changes to form templating that would simplify templating form fields (in the process of this we could handle many instances of this issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants