-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a field to identify if a Source is a printed book or a manuscript #1628
Comments
I would make it an IntegerField with two choices, 1 = Manuscript, 2 = Printed. (Don't do 0 because that's Falsey in Python, and liable to cause all sorts of problems.) Here's how we define a similar field in DIAMM: https://github.com/diamm/diamm/blob/main/diamm/models/data/source.py#L20-L37 And the actual field: https://github.com/diamm/diamm/blob/main/diamm/models/data/source.py#L56 You can also have a
|
@annamorphism What would you call this in the user display? The best I've come up with so far is "production method" |
"Source type"? "Document type" ? |
That's not a bad name, actually... |
or maybe it could just be Manuscript/Print in the same way there is Full Source/Fragmented? |
True...one implication of the way we've set up the field is that other options could be added in the future (if we wanted) ... but for now there are only the two so this is probably the clearest way to go. |
Ah--yes it could be interesting to be able to include things like stenciled sources or mixed-production sources...but mayeb that's a problem for the future. |
Yeah, I was picturing stenciling too as a future possibility. For now, I'll display it as |
This should be a checkmark or dropdown for printed.
The text was updated successfully, but these errors were encountered: