Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interacting with the neumes within a toggled syllable creates confusion #1117

Closed
JoyfulGen opened this issue Sep 28, 2023 · 2 comments
Closed
Labels
Severity: LOW Minor problem or a feature that would make life easier.

Comments

@JoyfulGen
Copy link
Contributor

Say a syllable contains neumes A and B. If you add a punctum to neume B, it automatically becomes its own syllable. This is expected behaviour. However, it can create strange situations within toggled syllables. For example:

  • Find or create a toggled syllable pair where Syllable A contains two neumes and Syllable B contains one.
  • Add a punctum to the second neume of Syllable A and group neumes and neume components.
  • You'll notice that that second neume automatically gets removed from syllable A and becomes its own syllable, Syllable C. However, what remains of Syllable A and Syllable B are still toggled. This no longer makes semantic sense, because Syllable A isn't the last syllable of the staff anymore, so it can't be toggled to a syllable on the next staff. Here's a demo, where Syllable A is blue and Syllable B is orange:
Syllable.C.in.toggle.sandwich.mov

Normally, Neon won't even give you the option of toggling two syllables unless they're the last and first syllables of their staff, so this toggle-sandwich situation is extra weird.

This is actually related to #1115 in that both issues happen because of fact that interacting with a neume within a syllable automatically removes that neume from the syllable.

@JoyfulGen JoyfulGen added the Severity: LOW Minor problem or a feature that would make life easier. label Sep 28, 2023
@yinanazhou
Copy link
Member

Hi @JoyfulGen I've pushed the changes. Please let me know if there are any edge cases not covered. Thanks!

@JoyfulGen
Copy link
Contributor Author

@yinanazhou it all looks good! The prompt to untoggle always appears when I try to do something weird, so toggle-related confusion is gone! Closing issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: LOW Minor problem or a feature that would make life easier.
Projects
None yet
Development

No branches or pull requests

2 participants