Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old Salzinnes files have accidentals that don't appear in Neon #1234

Open
JoyfulGen opened this issue Jul 11, 2024 · 3 comments
Open

Old Salzinnes files have accidentals that don't appear in Neon #1234

JoyfulGen opened this issue Jul 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@JoyfulGen
Copy link
Contributor

Salzinnes files that were corrected 3 years ago have accidentals that are encoded like this:

<accid xml:id="accid-0000001162587191" facs="#zone-0000001832122871" accid="f"/>

And those accidentals don't appear on Neon. I can add a new accidental in the same spot and that accidental does appear, but in the MEI files there are two accid elements in a row, like so:

<accid xml:id="accid-0000002078940876" facs="#zone-0000001781106505" accid="f"/>
<accid xml:id="a1mor0hh" facs="#zwtz2bp" accid="f"/>

My manual correction for this would to remove the old accid element in the MEI file manually and then add a new one in Neon. Is there another way to do this?

Here are a couple of files with the invisible accidentals:
CDN-Hsmu_M2149.L4_004r.mei.zip
CDN-Hsmu_M2149.L4_014r.mei.zip

@JoyfulGen JoyfulGen added the bug Something isn't working label Jul 11, 2024
@yinanazhou
Copy link
Member

The accid is not showing because the zone@uly is too large. This is an example:

<zone xml:id="zone-0000001781106505" ulx="1709" uly="28181" lrx="1774" lry="1564"/>
<zone xml:id="zone-0000001239018847" ulx="3443" uly="28181" lrx="3508" lry="1564"/>
<zone xml:id="zone-0000000717178383" ulx="2254" uly="23383" lrx="2323" lry="6365"/>

I tried to remove the last digit of zone@uly value. and it works:
image

@JoyfulGen
Copy link
Contributor Author

JoyfulGen commented Jul 12, 2024

@yinanazhou ok cool! Incidentally, is that the 004r file I uploaded? The obliques are looking rough...

@JoyfulGen
Copy link
Contributor Author

Update: I tried removing the last digit and the flats appear exactly where they are in your screenshot, but that doesn't correspond to where they are on the page:

uly of flats wrong

The x coordinates seem to be correct, but the y coordinates are way off. There aren't many files with this problem, so I think I'll just remove the flat from the MEI manually and add them quickly in Neon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants