Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neon staging] Liquescents and obliques look weird #1236

Open
JoyfulGen opened this issue Jul 18, 2024 · 6 comments
Open

[Neon staging] Liquescents and obliques look weird #1236

JoyfulGen opened this issue Jul 18, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@JoyfulGen
Copy link
Contributor

When I uploaded Einsie 138v to Neon staging, both obliques and liquescents separated from their stems:

This is the file: CH-E_611_138v.mei.zip

And this is what it looks like:

liquescents and obliques on staging

I looked at the mei, and I can't tell what's wrong with the obliques. With the liquescents, however, I noticed that a second liquescent line appears under the first one when I upload the file to staging.

So this is the original encoding of the liquescent neume:

<neume xml:id="nns7rm4">
    <nc xml:id="m-02f2cef8-d6dc-406d-81d4-2a61de1a0c05" facs="#m-7d690635-ae09-4304-896f-8b93f9a6864c" oct="4" pname="c" curve="a">
      <liquescent xml:id="m-903fa7ce-9861-46b5-b8d1-bd24380386c0"/>
    </nc>
</neume>

And this is after upload:

<neume xml:id="nns7rm4">
    <nc xml:id="m-02f2cef8-d6dc-406d-81d4-2a61de1a0c05" facs="#m-7d690635-ae09-4304-896f-8b93f9a6864c" oct="4" pname="c" curve="a">
      <liquescent xml:id="m-903fa7ce-9861-46b5-b8d1-bd24380386c0"/>
      <liquescent xml:id="m-b9d67f8b-d3f5-41a7-9817-3d77108aabf5"/>
   </nc>
</neume>

I checked previous issues I wrote about staging and obliques looked fine, so this appears to be a relatively recent phenomenon.

@JoyfulGen JoyfulGen added the bug Something isn't working label Jul 18, 2024
yinanazhou added a commit to DDMAL/verovio that referenced this issue Aug 1, 2024
@yinanazhou yinanazhou added to-be-merged Fixed, but waiting for RISM to merge changes to develop. and removed bug Something isn't working labels Aug 1, 2024
yinanazhou added a commit that referenced this issue Aug 1, 2024
yinanazhou added a commit to yinanazhou/Neon that referenced this issue Aug 1, 2024
@yinanazhou
Copy link
Member

The changes has been merged!

@JoyfulGen
Copy link
Contributor Author

Liquescents are doing a funny thing again! Some of them are fine, but some of them are appearing as teeny tiny puncta. Behold:

148r smol neumes

If I use the neume component selector and try to change their head shape, nothing happens. However, I can delete them and input a new liquescent that looks totally normal.

I don't know why some liquescents are fine and some aren't! I tried looking at the MEI and I can't find the difference... But I can tell you Einsie 148r has a lot of the tiny liquescents:

CH-E_611_148r.mei.zip

@JoyfulGen JoyfulGen reopened this Aug 6, 2024
@annamorphism
Copy link

aw, little baby puncta!! (sorry, I have no insight into the issue...)

@JoyfulGen
Copy link
Contributor Author

Small addendum: the fact that using the "Change Head Shape" function doesn't work is actually due to this issue #1239.

@yinanazhou
Copy link
Member

Hi! This is because in this file, the parent <nc> of the <liquescent> doesn't have an associated @curve value for some reason. Does this happen to a lot of the files?

@yinanazhou yinanazhou added bug Something isn't working and removed to-be-merged Fixed, but waiting for RISM to merge changes to develop. labels Aug 14, 2024
@JoyfulGen
Copy link
Contributor Author

@yinanazhou I'd say it was happening 1-4 times in every file I was reviewing (which are in the 140-160 range of Einsie)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants