Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staging] Clef misbehaviours #1248

Open
yinanazhou opened this issue Nov 28, 2024 · 5 comments
Open

[Staging] Clef misbehaviours #1248

yinanazhou opened this issue Nov 28, 2024 · 5 comments
Labels
to-be-merged Fixed, but waiting for RISM to merge changes to develop.

Comments

@yinanazhou
Copy link
Member

yinanazhou commented Nov 28, 2024

A pitch of a newly inserted glyph is calculated assuming top line as c4, but the glyph is placed based on the clef.
Expected behaviour:
The pitch should be calculated based on the clef.

@yinanazhou
Copy link
Member Author

Hi @fujinaga, @JoyfulGen, and @annamorphism , I would like to confirm with you where the default clef should be when there is no clef found. Should it be:

  1. Use the last clef we can find from previous staves; or
  2. Set the top line as C4

yinanazhou added a commit to DDMAL/verovio that referenced this issue Nov 30, 2024
yinanazhou added a commit to DDMAL/verovio that referenced this issue Nov 30, 2024
@yinanazhou yinanazhou added the to-be-merged Fixed, but waiting for RISM to merge changes to develop. label Nov 30, 2024
@yinanazhou
Copy link
Member Author

Hi @JoyfulGen, staging should be good after the changes get merged.

@JoyfulGen
Copy link
Contributor

Hi @fujinaga, @JoyfulGen, and @annamorphism , I would like to confirm with you where the default clef should be when there is no clef found. Should it be:

1. Use the last clef we can find from previous staves; or

2. Set the top line as C4

I think at the meeting we agreed for option 1! @annamorphism can confirm. I do have a question though: what will happen when the missing clef is at the top of the page and there's no clef on a previous staff? Will the default clef then be top line C4?

@annamorphism
Copy link

good catch! I think it does make sense to have the top line as the clef iff there is no "previous staff."

@fujinaga
Copy link
Member

fujinaga commented Dec 2, 2024

Is the top line for the c-clef the most common position?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-be-merged Fixed, but waiting for RISM to merge changes to develop.
Projects
None yet
Development

No branches or pull requests

4 participants