Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support English and French in detail page #121

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kunfang98927
Copy link
Contributor

Resolves: #120

@yinanazhou
Copy link
Member

The webpage content will be automatically translated by google translate. I would suggest only update the instrument name, and maybe keep the instrument name selector?

@kunfang98927
Copy link
Contributor Author

I would like to confirm some details:

  • For the instrument detail page in the first image below, we will only need the instrument name (in red rectangle) to be English/French based on the active_language of the current webpage. Also, we will need a language selector (similar to which in instrument list page in the second image below).
  • For the table headers (in green rectangles), we will want English only. And we can use google translate for them.

image
image

@yinanazhou
Copy link
Member

Yes, one more note is that edit buttons can also be google translated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support English and French in instrument detail page
2 participants