-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Languages for "add new instrument name" feature #157
Comments
A few comments:
It seems that at the very least all languages in Wikidata should be supported. |
Thank you for the comments.
No. I think using wikidata's language list is enough for us. |
@dchiller @fujinaga For the question "which languages are supported for adding item name to Wikidata", I haven't figured out the exact answer. Here is some other possible ways to get a language list.
So I think if we are going to use this language table, we can just copy it and clean the data as we want.
Between these two methods, I prefer the first one which is to create our own clean language table. |
Method 1 is fine. |
I also found this incredibly difficult to definitively determine. The results of my research is in #27 -- you found some of the same ways I did.
I actually think this is a case of Wikidata being wrong and therefore maybe a point against this table (because it relies on the contents of Wikidata to populate). In the Universal Language Selector, |
This is also maybe a useful tool (there's a link to the codebase which we could potentially pull from): https://codelookup.toolforge.org/ |
Before I complete the "add new instrument name" feature. I have a question about updating language list in UMIL.
Based on my design, users can add new names to an instrument in a modal like this:
After the "publish" button is clicked, "wikidata_id" of the instrument, "language_code", "name", "source" will be saved to database. A new instrument name will be created by the following script in
views/instrument_list.py
:According to our model design in
models/instrument_name.py
,we should always choose a "instrument" and "language" from our database when publishing new instrument names. However, currently we only have two languages, "English" and "French", in our database. So should we synchronize as many languages as we can with Wikidata, or should we have our own language list (can be a subset of wikidata's language list) in UMIL so that users can choose from the list when adding new names for a instrument? @fujinaga @dchiller
The text was updated successfully, but these errors were encountered: