Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change internal position to use top left of the viewport #360

Open
jeromepl opened this issue Aug 25, 2016 · 0 comments
Open

Change internal position to use top left of the viewport #360

jeromepl opened this issue Aug 25, 2016 · 0 comments

Comments

@jeromepl
Copy link
Contributor

This is a follow up to #321.

As mentioned by @wabain,
"Internal positioning calculations need to be page-relative to handle scaling across zoom levels. However, currently they're all done based on the public-facing coordinate system, which is page top to viewport centre. This is hard to reason about, so the internal stuff should use the distance from page top left to viewport top left."
"As a workaround for the difficulty of the coordinate system, various internal methods use varying coordinate information. This could/should be made more consistent."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants